-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 #12829
Merged
chunyu3
merged 12 commits into
Azure:master
from
greenms:dev-redisenterprise-Microsoft.Cache-2021-03-01
Feb 9, 2021
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1211ad7
Adds base for updating Microsoft.Cache from version preview/2020-10-0…
greenms 72fa2b3
Updates readme
greenms ac18ed4
Updates API version in new specs and examples
greenms af81ba0
Add support for persistence and fix other typos
greenms 83e7ebf
Fix SDK Warning: R2063 OperationIdNounConflictingModelNames
greenms 5d67284
Fix spellcheck error
greenms 8da67e4
Fix acronym capitalization in descriptions
greenms cb5b7de
Replace local parameters with common-types parameters
greenms 918725d
Use naming convention consistent with Azure documentation
greenms c074f14
Update word choice, remove deprecated x-ms-code-generation-setting, a…
greenms 4681e83
Add x-ms-secret extension and make TLS version a string enum
greenms 72aa952
Suppress errors about secrets being sent in responses
greenms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -664,6 +664,7 @@ Français | |
| freeflow | ||
| frontdoor | ||
| fsaction | ||
| fsynced | ||
| Fulfilment | ||
| fullmetadata | ||
| Fulltext | ||
|
|
||
19 changes: 19 additions & 0 deletions
19
...rise/resource-manager/Microsoft.Cache/stable/2021-03-01/examples/OperationsStatusGet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "subid", | ||
| "location": "West US", | ||
| "operationId": "testoperationid", | ||
| "api-version": "2021-03-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/providers/Microsoft.Cache/locations/westus/operationStatus/testoperationid", | ||
| "name": "testoperationid", | ||
| "startTime": "2017-01-01T13:13:13.933Z", | ||
| "endTime": "2017-01-01T16:13:13.933Z", | ||
| "status": "Succeeded" | ||
| } | ||
| } | ||
| } | ||
| } | ||
82 changes: 82 additions & 0 deletions
82
...se/resource-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseCreate.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| { | ||
| "parameters": { | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid", | ||
| "parameters": { | ||
| "location": "West US", | ||
| "sku": { | ||
| "name": "EnterpriseFlash_F300", | ||
| "capacity": 3 | ||
| }, | ||
| "zones": [ | ||
| "1", | ||
| "2", | ||
| "3" | ||
| ], | ||
| "properties": { | ||
| "minimumTlsVersion": "1.2" | ||
| }, | ||
| "tags": { | ||
| "tag1": "value1" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "201": { | ||
| "body": { | ||
| "name": "cache1", | ||
| "type": "Microsoft.Cache/redisEnterprise", | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1", | ||
| "location": "West US", | ||
| "sku": { | ||
| "name": "EnterpriseFlash_F300", | ||
| "capacity": 3 | ||
| }, | ||
| "zones": [ | ||
| "1", | ||
| "2", | ||
| "3" | ||
| ], | ||
| "properties": { | ||
| "provisioningState": "Creating", | ||
| "resourceState": "Creating", | ||
| "hostName": "cache1.westus.something.azure.net", | ||
| "redisVersion": "5", | ||
| "minimumTlsVersion": "1.2" | ||
| }, | ||
| "tags": { | ||
| "tag1": "value1" | ||
| } | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "name": "cache1", | ||
| "type": "Microsoft.Cache/redisEnterprise", | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1", | ||
| "location": "West US", | ||
| "sku": { | ||
| "name": "EnterpriseFlash_F300", | ||
| "capacity": 3 | ||
| }, | ||
| "zones": [ | ||
| "1", | ||
| "2", | ||
| "3" | ||
| ], | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "resourceState": "Running", | ||
| "hostName": "cache1.westus.something.azure.net", | ||
| "redisVersion": "5", | ||
| "minimumTlsVersion": "1.2" | ||
| }, | ||
| "tags": { | ||
| "tag1": "value1" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
108 changes: 108 additions & 0 deletions
108
...ce-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesCreate.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "default", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid", | ||
| "parameters": { | ||
| "properties": { | ||
| "clientProtocol": "Encrypted", | ||
| "clusteringPolicy": "EnterpriseCluster", | ||
| "evictionPolicy": "AllKeysLRU", | ||
| "persistence": { | ||
| "aofEnabled": true, | ||
| "aofFrequency": "1s" | ||
| }, | ||
| "port": 10000, | ||
| "modules": [ | ||
| { | ||
| "name": "RedisBloom", | ||
| "args": "ERROR_RATE 0.00 INITIAL_SIZE 400" | ||
| }, | ||
| { | ||
| "name": "RedisTimeSeries", | ||
| "args": "RETENTION_POLICY 20" | ||
| }, | ||
| { | ||
| "name": "RediSearch" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1/databases/default", | ||
| "name": "cache1/default", | ||
| "type": "Microsoft.Cache/redisEnterprise/databases", | ||
| "properties": { | ||
| "provisioningState": "Updating", | ||
| "resourceState": "Updating", | ||
| "clientProtocol": "Encrypted", | ||
| "clusteringPolicy": "EnterpriseCluster", | ||
| "evictionPolicy": "AllKeysLRU", | ||
| "persistence": { | ||
| "aofEnabled": true, | ||
| "aofFrequency": "1s" | ||
| }, | ||
| "port": 10000, | ||
| "modules": [ | ||
| { | ||
| "name": "RedisBloom", | ||
| "args": "ERROR_RATE 0.00 INITIAL_SIZE 400", | ||
| "version": "1.0.0" | ||
| }, | ||
| { | ||
| "name": "RedisTimeSeries", | ||
| "args": "RETENTION_POLICY 20", | ||
| "version": "1.0.0" | ||
| }, | ||
| { | ||
| "name": "RediSearch", | ||
| "args": "", | ||
| "version": "1.0.0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1/databases/db1", | ||
| "name": "cache1/db1", | ||
| "type": "Microsoft.Cache/redisEnterprise/databases", | ||
| "properties": { | ||
| "provisioningState": "Creating", | ||
| "resourceState": "Creating", | ||
| "clientProtocol": "Encrypted", | ||
| "clusteringPolicy": "EnterpriseCluster", | ||
| "evictionPolicy": "AllKeysLRU", | ||
| "persistence": { | ||
| "aofEnabled": true, | ||
| "aofFrequency": "1s" | ||
| }, | ||
| "port": 10000, | ||
| "modules": [ | ||
| { | ||
| "name": "RedisBloom", | ||
| "args": "ERROR_RATE 0.00 INITIAL_SIZE 400", | ||
| "version": "1.0.0" | ||
| }, | ||
| { | ||
| "name": "RedisTimeSeries", | ||
| "args": "RETENTION_POLICY 20", | ||
| "version": "1.0.0" | ||
| }, | ||
| { | ||
| "name": "RediSearch", | ||
| "args": "", | ||
| "version": "1.0.0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
...ce-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesDelete.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "db1", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Azure-AsyncOperation": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationStatus...", | ||
| "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationResult..." | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
...ce-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesExport.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "default", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid", | ||
| "parameters": { | ||
| "sasUri": "https://contosostorage.blob.core.window.net/urlToBlobContainer?sasKeyParameters" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Azure-AsyncOperation": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationStatus...", | ||
| "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationResult..." | ||
| } | ||
| } | ||
| } | ||
| } |
37 changes: 37 additions & 0 deletions
37
...ource-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesGet.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "default", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1/databases/default", | ||
| "name": "cache1/default", | ||
| "type": "Microsoft.Cache/redisEnterprise/databases", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "resourceState": "Running", | ||
| "clientProtocol": "Encrypted", | ||
| "clusteringPolicy": "OSSCluster", | ||
| "evictionPolicy": "AllKeysLRU", | ||
| "persistence": { | ||
| "rdbEnabled": true, | ||
| "rdbFrequency": "12h" | ||
| }, | ||
| "port": 10000, | ||
| "modules": [ | ||
| { | ||
| "name": "RediSearch", | ||
| "args": "", | ||
| "version": "1.0.0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
...ce-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesImport.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "default", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid", | ||
| "parameters": { | ||
| "sasUri": "https://contosostorage.blob.core.window.net/urltoBlobFile?sasKeyParameters" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "Azure-AsyncOperation": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationStatus...", | ||
| "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Cache/...pathToOperationResult..." | ||
| } | ||
| } | ||
| } | ||
| } |
40 changes: 40 additions & 0 deletions
40
...ger/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesListByCluster.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "parameters": { | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Cache/redisEnterprise/cache1/databases/default", | ||
| "name": "cache1/default", | ||
| "type": "Microsoft.Cache/redisEnterprise/databases", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "resourceState": "Running", | ||
| "clientProtocol": "Encrypted", | ||
| "clusteringPolicy": "OSSCluster", | ||
| "evictionPolicy": "AllKeysLRU", | ||
| "persistence": { | ||
| "rdbEnabled": true, | ||
| "rdbFrequency": "12h" | ||
| }, | ||
| "port": 10000, | ||
| "modules": [ | ||
| { | ||
| "name": "RediSearch", | ||
| "args": "", | ||
| "version": "1.0.0" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...-manager/Microsoft.Cache/stable/2021-03-01/examples/RedisEnterpriseDatabasesListKeys.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "parameters": { | ||
| "databaseName": "default", | ||
| "clusterName": "cache1", | ||
| "resourceGroupName": "rg1", | ||
| "api-version": "2021-03-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "primaryKey": "<primaryKey>", | ||
| "secondaryKey": "<secondaryKey>" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be operationsStatus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Do I re-open this PR with this fix or my other PR: #12943 ? Or would I use this same branch and create a brand new PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say a tiny separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay great. here it is: #12967