[Hub Generated] Review request for Microsoft.Cache to add version stable/2021-03-01 #12829

greenms · 2021-02-04T03:44:05Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? March 2021
When you expect to publish swagger? ASAP
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…1-preview to version 2021-03-01

openapi-workflow-bot · 2021-02-04T03:44:08Z

Hi, @greenms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-04T03:44:09Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-04T03:44:10Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 996bbc4. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redisenterprise/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.RedisEnterprise [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.RedisEnterprise.2.0.0.nupkg
- Microsoft.Azure.Management.RedisEnterprise.2.0.0.snupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 996bbc4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-redisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DatabaseUpdate has a new parameter persistence
info	[Changelog]   - Model Database has a new parameter persistence
info	[Changelog]   - Added operation PrivateLinkResourcesOperations.list_by_cluster
info	[Changelog]   - Added operation group OperationsStatusOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Removed operation PrivateLinkResourcesOperations.list_by_redis_enterprise_cache
info	[Changelog]   - Removed operation group GetOperations

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 996bbc4. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️redisenterprise/mgmt/2021-03-01/redisenterprise [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/redisenterprise/mgmt/2020-10-01-preview/redisenterprise [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 996bbc4. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-22 02:57:08 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-redisenterprise"
cmderr	[generate.py] 2021-02-22 02:57:08 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-22 02:57:08 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.16 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/redisenterprise/azure-resourcemanager-redisenterprise --java.namespace=com.azure.resourcemanager.redisenterprise   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/redisenterprise/resource-manager/readme.md
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [POM][Skip] pom already has module azure-resourcemanager-redisenterprise
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-22 02:57:46 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-redisenterprise [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Got artifact_id: azure-resourcemanager-redisenterprise
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Got artifact: azure-resourcemanager-redisenterprise-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Got artifact: azure-resourcemanager-redisenterprise-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Got artifact: azure-resourcemanager-redisenterprise-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG Match jar package: azure-resourcemanager-redisenterprise-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-22 03:01:20 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12829/azure-sdk-for-java/azure-resourcemanager-redisenterprise/azure-resourcemanager-redisenterprise-1.0.0-beta.1.jar\" -o azure-resourcemanager-redisenterprise-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-redisenterprise -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-redisenterprise-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 996bbc4. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/redisenterprise/resource-manager/readme.md

️✔️@azure/arm-redisenterprisecache [View full logs] [Release SDK Changes]

azure-arm-redisenterprisecache-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/redisEnterpriseManagementClient.js → ./dist/arm-redisenterprisecache.js...
cmderr	[npmPack] created ./dist/arm-redisenterprisecache.js in 408ms

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-04T04:13:25Z

Hi, @greenms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @chunyu3

...tion/redisenterprise/resource-manager/Microsoft.Cache/stable/2021-03-01/redisenterprise.json

…nd fix operationId

greenms · 2021-02-06T21:37:02Z

To address the following (3) code changes in the Swagger, I created a breaking change intake work item: https://msazure.visualstudio.com/One/_workitems/edit/9272990

(1): Modifying operation Id (correcting to Noun_Verb format):
BEFORE: "operationId": "Get_OperationStatus"
AFTER: "operationId": "OperationsStatus_Get"

(2): Changing name of client class in SDK to meet conventions across Azure:
BEFORE: "x-ms-code-generation-settings": { "name": "redisenterpriseClient" }
AFTER: "title": "RedisEnterpriseManagementClient" (the x-ms-code-generation-setting extension is being deprecated)

(3): Modifying operation Id (correcting for consistency with Databases listBy operationId):
BEFORE: "operationId": "PrivateLinkResources_ListByRedisEnterpriseCache"
AFTER: "operationId": "PrivateLinkResources_ListByCluster"

...tion/redisenterprise/resource-manager/Microsoft.Cache/stable/2021-03-01/redisenterprise.json

TimLovellSmith

+secret annotations

openapi-workflow-bot · 2021-02-08T20:40:59Z

Hi @greenms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

TimLovellSmith · 2021-02-12T00:09:00Z

...erprise/resource-manager/Microsoft.Cache/stable/2021-03-01/examples/OperationsStatusGet.json

+  "responses": {
+    "200": {
+      "body": {
+        "id": "/subscriptions/subid/providers/Microsoft.Cache/locations/westus/operationStatus/testoperationid",


Shouldn't this be operationsStatus?

Good catch! Do I re-open this PR with this fix or my other PR: #12943 ? Or would I use this same branch and create a brand new PR ?

I'd say a tiny separate PR.

Okay great. here it is: #12967

00Kai0 · 2021-02-22T02:51:46Z

/azp run

…ble/2021-03-01 (Azure#12829) * Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add support for persistence and fix other typos * Fix SDK Warning: R2063 OperationIdNounConflictingModelNames * Fix spellcheck error * Fix acronym capitalization in descriptions * Replace local parameters with common-types parameters * Use naming convention consistent with Azure documentation * Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId * Add x-ms-secret extension and make TLS version a string enum * Suppress errors about secrets being sent in responses

greenms and others added 5 commits February 2, 2021 19:06

Adds base for updating Microsoft.Cache from version preview/2020-10-0…

1211ad7

…1-preview to version 2021-03-01

Updates readme

72fa2b3

Updates API version in new specs and examples

ac18ed4

Add support for persistence and fix other typos

af81ba0

Fix SDK Warning: R2063 OperationIdNounConflictingModelNames

83e7ebf

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Feb 4, 2021

greenms marked this pull request as ready for review February 4, 2021 03:56

greenms requested review from ArcturusZhang, jsntcy, msyyc and qiaozha as code owners February 4, 2021 03:56

openapi-assignment-bot bot assigned chunyu3 Feb 4, 2021

Fix spellcheck error

5d67284

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 4, 2021

greenms requested a review from TimLovellSmith February 4, 2021 04:14

This comment has been minimized.

Sign in to view