New backup service API version 2021-01-01 #12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @anjorsh Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Hi, @anjorsh your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'PUT' operation 'PrivateEndpointConnection_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L320 |
|
| 'PUT' operation 'ProtectionContainers_Register' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L2305 |
|
| 'DELETE' operation 'ProtectionContainers_Unregister' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L2374 |
|
| The operation 'ProtectedItems_CreateOrUpdate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L786 |
|
| The operation 'ProtectedItems_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L865 |
|
| The operation 'ProtectedItemOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L934 |
|
| The operation 'ProtectionPolicies_CreateOrUpdate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L1355 |
|
| The operation 'JobCancellations_Trigger' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L1656 |
|
| The operation 'JobOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L1705 |
|
| The operation 'ExportJobsOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.RecoveryServices/stable/2021-01-01/bms.json#L1767 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/recoveryservicesbackup/resource-manager/readme.md tag: specification/recoveryservicesbackup/resource-manager/readme.md#tag-package-2021-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 37 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-12-01/bms.json <---> new: stable/2021-01-01/bms.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L264:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName}/operationsStatus/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L430:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L703:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L905:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L978:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L1049:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/restore' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L1116:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L1192:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L1245:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupPolicies/{policyName}/operationResults/{operationId}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2020-12-01/bms.json#L1398:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
Hi @anjorsh, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 25, 2021
This was referenced Jan 25, 2021
… added ListRecoveryPointsRecommendedForMoveRequest
pilor
reviewed
Jan 27, 2021
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json
Outdated
Show resolved
Hide resolved
|
Thank you @pilor for review! @ArcturusZhang / @lirenhe / @ChenTanyi: Can you please help getting this PR merged? |
njuCZ
approved these changes
Feb 1, 2021
This was referenced Feb 1, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adding a new 2021-01-01 version copied from 2020-12-01 * Updating the API version in all 2021-01-01 examples * Changes for 2021-01-01 API Version * Examples for 2021-01-01 API Version * Updated entities in 2018-12-20 spec to match optional properties added in 2021-01-01 * Updated readme.md for 2021-01 version * Fixed camelCasing in URLs * Fixed MoveRecoveryPoint Example * Added Definition of RecoveryPointMoveReadinessInfo in 2018-12-20 * Added example for RecoveryPointsRecommendedForMove_List operation * Undoing delete of ReadOnly properties in 2018-12-20 * Added default error response for all operations * Updating readme.md for go, java and ruby * Updating enums in 2020-12-01 version to fix go SDK * Added missing 200 response for two Delete operations * Fixed Prettier issues * Added missing 200 response in examples * Changed MoveRPAcrossTiersRequestResource to MoveRPAcrossTiersRequest, added ListRecoveryPointsRecommendedForMoveRequest * Removing changes from old API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.