Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure CDN : Change casing for subscription ID and API version #12159

Merged
merged 5 commits into from
Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5556,7 +5556,7 @@
"in": "query",
"required": true,
"type": "string",
"description": "Version of the API to be used with the client request. Current version is 2017-04-02."
"description": "Version of the API to be used with the client request. Current version is 2020-09-01."
},
"resourceGroupNameParameter": {
"name": "resourceGroupName",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5631,7 +5631,7 @@
"in": "query",
"required": true,
"type": "string",
"description": "Version of the API to be used with the client request. Current version is 2017-04-02."
"description": "Version of the API to be used with the client request. Current version is 2020-09-01."
},
"resourceGroupNameParameter": {
"name": "resourceGroupName",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -91,10 +91,10 @@
"$ref": "#/parameters/PolicyNameParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -131,10 +131,10 @@
"$ref": "#/parameters/PolicyNameParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
},
{
"description": "Policy to be created.",
Expand Down Expand Up @@ -193,10 +193,10 @@
"$ref": "#/parameters/PolicyNameParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
},
{
"description": "CdnWebApplicationFirewallPolicy parameters to be patched.",
Expand Down Expand Up @@ -249,10 +249,10 @@
"$ref": "#/parameters/PolicyNameParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -280,10 +280,10 @@
"operationId": "ManagedRuleSets_List",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/ApiVersionParameter"
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
Expand Down Expand Up @@ -888,19 +888,19 @@
}
},
"parameters": {
"SubscriptionIdParameter": {
"subscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"description": "Azure Subscription ID.",
"required": true,
"type": "string"
},
"ApiVersionParameter": {
"apiVersionParameter": {
"name": "api-version",
Comment on lines -891 to 899

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there reason to make these casing changes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make these casing changes because the Python SDK generation was failing. It was failing because the casing for subscriptionIdParameter and apiVersionParameter was not consistent in the afdx.json and cdn.json files.

"in": "query",
"required": true,
"type": "string",
"description": "Version of the API to be used with the client request. Current version is 2019-09-01."
"description": "Version of the API to be used with the client request. Current version is 2020-09-01."
},
"PolicyNameParameter": {
"name": "policyName",
Expand Down