Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview #11869

Merged
merged 6 commits into from
Jan 12, 2021
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview #11869

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e189f20
Fix swagger KPIs issue
jiacheng-L Nov 19, 2020
6cb8c9d
Address PR comments
jiacheng-L Dec 4, 2020
82a8544
Move error response to Common.json
jiacheng-L Dec 7, 2020
52fc7f7
Run PrettierCheck to update the new json file format
jiacheng-L Dec 8, 2020
2ce092a
Add integer format for keyVault 2020-04-01-preview version per swagge…
jiacheng-L Dec 9, 2020
7ff2289
Fix copy/paste error
jiacheng-L Jan 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
}
},
"404": {
"$ref": "#/responses/BadRequest"
"$ref": "#/responses/NotFound"
}
},
"x-ms-examples": {
Expand Down Expand Up @@ -1198,7 +1198,15 @@
},
"provisioningState": {
"type": "string",
"description": "Provisioning state of the vault."
"description": "Provisioning state of the vault.",
"enum": [
"Succeeded",
"RegisteringDns"
],
"x-ms-enum": {
"name": "ProvisioningState",
"modelAsString": true
}
},
"privateEndpointConnections": {
"readOnly": true,
Expand Down Expand Up @@ -1694,7 +1702,7 @@
},
"etag": {
"type": "string",
"description": "Modified whenever the user or NRP changes the state of PE connection."
"description": "Modified whenever there is a change in the state of private endpoint connection."
}
},
"allOf": [
Expand Down Expand Up @@ -1744,7 +1752,14 @@
},
"actionsRequired": {
"type": "string",
"description": "A message indicating if changes on the service provider require any updates on the consumer."
"description": "A message indicating if changes on the service provider require any updates on the consumer.",
"enum": [
"None"
],
"x-ms-enum": {
"name": "ActionsRequired",
"modelAsString": true
}
}
},
"description": "An object that represents the approval state of the private link connection."
Expand Down
35 changes: 21 additions & 14 deletions ...tion/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/secrets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,13 @@
}
},
"400": {
"description": "Bad request.",
"x-ms-error-response": true
"$ref": "#/responses/BadRequest"
},
"404": {
"description": "The specified resource does not exist.",
"x-ms-error-response": true
"$ref": "#/responses/NotFound"
},
"409": {
"description": "A conflict occurred to prevent the operation from completing.",
"x-ms-error-response": true
"$ref": "#/responses/Conflict"
}
},
"x-ms-examples": {
Expand Down Expand Up @@ -155,16 +152,13 @@
}
},
"400": {
"description": "Bad request.",
"x-ms-error-response": true
"$ref": "#/responses/BadRequest"
},
"404": {
"description": "The specified resource does not exist.",
"x-ms-error-response": true
"$ref": "#/responses/NotFound"
},
"409": {
"description": "A conflict occurred to prevent the operation from completing.",
"x-ms-error-response": true
"$ref": "#/responses/Conflict"
}
},
"x-ms-examples": {
Expand Down Expand Up @@ -222,8 +216,7 @@
}
},
"404": {
"description": "The specified resource does not exist.",
"x-ms-error-response": true
"$ref": "#/responses/NotFound"
}
},
"x-ms-examples": {
Expand Down Expand Up @@ -483,5 +476,19 @@
"user_impersonation": "impersonate your user account"
}
}
},
"responses": {
"BadRequest": {
"description": "Bad request.",
"x-ms-error-response": true
},
"NotFound": {
"description": "The specified resource does not exist.",
"x-ms-error-response": true
},
"Conflict": {
"description": "A conflict occurred to prevent the operation from completing.",
"x-ms-error-response": true
}
}
}