Text Analytics v3.1preview.3 deserialization fixes for SDK #11530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2020 09:23
…bhahn/ta_3.1preview.1_deserialization_fixes
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a different format than the previous one. New: TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json#L100:9 Old: TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json#L100:9 |
|
The new version has a different type 'object' than the previous one 'array'. New: TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json#L1047:13 Old: TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json#L1047:13 |
️⚠️~[Staging] LintDiff: 1 Warnings warning [Detail] [Expand]
- Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
| Rule | Message |
|---|---|
| Guid used in model definition 'JobMetadata' for property 'jobId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. New: TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json#L1919 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Hi @abhahn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Nov 4, 2020
deyaaeldeen
reviewed
Nov 4, 2020
| @@ -99,7 +99,7 @@ | |||
| "summary": "Get analysis status and results", | |||
| "parameters": [ | |||
| { | |||
| "$ref": "#/parameters/JobId" | |||
| "$ref": "#/parameters/AnalyzeJobId" | |||
There was a problem hiding this comment.
is that because of the uuid issue?
There was a problem hiding this comment.
Yes, I decided to add a new value for the job ID for Analyze because Guid has already been implemented for the Healthcare service and I didn't want to break anything. The service team who owns the Analyze frontend has told us that they won't have time to change their job ID to a Guid in time for the preview release.
mssfang
approved these changes
Nov 4, 2020
suhas92
approved these changes
Nov 4, 2020
|
Hey @lmazuel , I am getting a warning about breaking changes in this PR. Since we haven't released these APIs yet and are getting ready for the release of v3.1-preview.3 is there anything else I need to do to make this PR mergeable? |
|
@varunkumta or @lmazuel , could I get some help merging this PR due the the breaking change review? The changes are for an unreleased preview version, so we won't be breaking anything in production. |
iscai-msft
approved these changes
Nov 5, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…SDK (Azure#11530) Co-authored-by: Abigail Hartman <abhahn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.