VM and VMSS licenseType description update, allows value to be updated #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-09-30 |
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Hi, @Sandido your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ArcturusZhang |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Nov 2, 2020
|
Hi @Sandido is this good to merge? |
edited all licensetype descriptions to not include the 'cannot update' clause.
|
Azure Pipelines successfully started running 1 pipeline(s). |
grizzlytheodore
approved these changes
Nov 3, 2020
|
removing label again and updating checklist in PR description - unchecked requirement for api review |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dochung4
reviewed
Nov 3, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
smotwani
reviewed
Nov 4, 2020
| @@ -9040,7 +9040,7 @@ | |||
| }, | |||
| "licenseType": { | |||
| "type": "string", | |||
| "description": "Specifies that the image or disk that is being used was licensed on-premises. This element is only used for images that contain the Windows Server operating system. <br><br> Possible values are: <br><br> Windows_Client <br><br> Windows_Server <br><br> If this element is included in a request for an update, the value must match the initial value. This value cannot be updated. <br><br> For more information, see [Azure Hybrid Use Benefit for Windows Server](https://docs.microsoft.com/azure/virtual-machines/virtual-machines-windows-hybrid-use-benefit-licensing?toc=%2fazure%2fvirtual-machines%2fwindows%2ftoc.json) <br><br> Minimum api-version: 2015-06-15" | |||
| "description": "Specifies that the image or disk that is being used was licensed on-premises. This element is only used for images that contain the Windows Server operating system. <br><br> Possible values are: <br><br> Windows_Client <br><br> Windows_Server <br><br> For more information, see [Azure Hybrid Use Benefit for Windows Server](https://docs.microsoft.com/en-us/azure/virtual-machines/windows/hybrid-use-benefit-licensing) <br><br> Minimum api-version: 2015-06-15" | |||
There was a problem hiding this comment.
@rosingla needs to review this as we are now supporting AHUB for Linux VMs and we need to include the possible values for the license values support for Linux VMs and point to the reference for the more details.
There was a problem hiding this comment.
Suggested Description (same needs to be updated at all other places i.,e all other descriptions for licenseType field in this file) :
Specifies that the image or disk that is being used was licensed on-premises.
Possible values for Windows Server operating system are:
Windows_Client
Windows_Server
Possible values for Linux Server operating system are:
RHEL_BYOS (for RHEL)
SLES_BYOS (for SUSE)
For more information:
Azure Hybrid Use Benefit for Windows Server
Azure Hybrid Use Benefit For Linux Server
Minimum api-version: 2015-06-15
@smotwani / Abhishek/ Mayank to review and ack.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ready to merge. |
25 tasks
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
Azure#11485) * licensetype description update * all licensetype descriptions edited all licensetype descriptions to not include the 'cannot update' clause. * fix link * updating description for linux * Update compute.json * Update compute.json * Update compute.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for https://msazure.visualstudio.com/One/_workitems/edit/8323663
The description for the LicenseType property in the VM and VMSS properties indicate the property cannot be updated. This is not true. The value can be updated to 'Windows_Server' or 'Windows_Client' without issue for Windows OS resources.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.