[Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview #11360

greenms · 2020-10-23T19:58:09Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-10-23T19:58:14Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-10-23T19:58:27Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-23T19:59:48Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5307f79 with merge commit 9abfdcf. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.RedisEnterprise [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 29 Oct 2020 09:10:59 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:FCBD:1BEE5F4:1F8B7D0:5F9A8723","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-23T19:59:49Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5307f79 with merge commit 9abfdcf. SDK Automation 13.0.17.20200918.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/_redisenterprise_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/models/_redisenterprise_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_databases_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_get_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_private_endpoint_connections_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_private_link_resources_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_redis_enterprise_database_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/operations/_redis_enterprise_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/redisenterprise/version.py

openapi-sdkautomation · 2020-10-23T19:59:49Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-23T19:59:51Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5307f79 with merge commit 9abfdcf. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-23T19:59:52Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-23T19:59:53Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-23T19:59:54Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5307f79 with merge commit 9abfdcf. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-23T19:59:57Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5307f79 with merge commit 9abfdcf. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

azure-pipelines · 2020-10-23T20:35:00Z

Azure Pipelines successfully started running 1 pipeline(s).

greenms · 2020-10-23T20:36:02Z

/azp run unifiedPipeline

azure-pipelines · 2020-10-23T20:36:07Z

No pipelines are associated with this pull request.

openapi-sdkautomation · 2020-10-23T20:39:03Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-10-23T21:41:07Z

Azure Pipelines successfully started running 1 pipeline(s).

greenms · 2020-10-23T21:41:23Z

/azp run unifiedPipeline

azure-pipelines · 2020-10-23T21:41:28Z

No pipelines are associated with this pull request.

TimLovellSmith

I see one small issue left, we should add the mutability details of clusteringPolicy

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json

azure-pipelines · 2020-10-26T23:32:49Z

Azure Pipelines successfully started running 1 pipeline(s).

TimLovellSmith

Looks about right to me, I guess we are now waiting for arm feedback.

openapi-workflow-bot · 2020-10-27T00:02:14Z

Hi, @greenms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2020-10-27T00:02:16Z

Hi, @greenms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @akning-ms

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json

TimLovellSmith · 2020-10-28T00:45:02Z

@majastrz But... having re-scanned the PR spec, it seems to me that having additional provisioningStates like "Disabling, Scaling, Updating" has always been allowed according to the following, which implies various updates can change the provisioningState after it reaches a terminal state:

"The provisioningState field should be returned on all future GETs, even after it is complete, until some other operation (e.g. a DELETE or UPDATE) causes it to transition to a non-terminal state."

majastrz · 2020-10-28T01:05:55Z

@majastrz But... having re-scanned the PR spec, it seems to me that having additional provisioningStates like "Disabling, Scaling, Updating" has always been allowed according to the following, which implies various updates can change the provisioningState after it reaches a terminal state:

"The provisioningState field should be returned on all future GETs, even after it is complete, until some other operation (e.g. a DELETE or UPDATE) causes it to transition to a non-terminal state."

Adding non-terminal states is allowed, but adding terminal states is not. DeleteFailed and Disabled are terminal states that aren't in the set of Succeeded, Failed, Canceled:

…ceState.

azure-pipelines · 2020-10-28T17:45:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…0-01-preview

majastrz

Latest changes look good. Signed off from ARM side.

azure-pipelines · 2020-10-28T18:32:02Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz · 2020-10-28T20:34:03Z

I got a notification that someone was asking about adding the Deleting state, but I can't see the comment. That's a non-terminal state, so that's definitely fine.

azure-pipelines · 2020-10-28T20:39:45Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz · 2020-10-28T20:42:36Z

Still signed off from ARM side.

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json

greenms · 2020-10-28T21:17:54Z

@akning-ms May it be merged?

…view/2020-10-01-preview (Azure#11360) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Initial updates for public preview * Add default error response. Add integer format. * Add 200 response to delete operations. * Add custom words for Redis Enterprise. * Update whitespace for prettier. * Update whitespace for prettier. * Update whitespace for prettier. * Revert "Update whitespace for prettier." This reverts commit 4f04b1b. * Revert "Update whitespace for prettier." This reverts commit ccca6d5. * Revert "Update whitespace for prettier." This reverts commit 3d72e6b. * Update whitespace for prettier. * Update Go settings * Including .NET SDK in list of SDKs automatically generated. * Update csharp settings. * Fix typo. * Updates addressing comments from reviewer. * Fix provisioningState errors. * Update clusteringPolicy description and related examples. * Remove Enterprise_E1 SKU. * Updates per comments from reviewer. * Remove illegal terminal states from provisioningState. Add new resourceState. * Utilize common properties from updated v2 types.json * Add 'Deleting' state to ProvisioningState enum.

greenms and others added 9 commits October 23, 2020 10:53

New Readme Config File

a2cdf38

New Go Language Readme Config File

3c6f301

New Typescript Language Readme Config File

92f5794

New Python Language Readme Config File

42b5855

New C# Language Readme Config File

14c1b48

New Ruby Language Readme Config File

ef9efd2

New Swagger Spec File

17ceeb0

New Swagger Example Spec File

46050fd

Initial updates for public preview

65aa3d9

greenms marked this pull request as ready for review October 23, 2020 20:15

openapi-assignment-bot bot assigned akning-ms Oct 23, 2020

Add default error response. Add integer format.

4243a6d

Add 200 response to delete operations.

6d1e945

TimLovellSmith requested changes Oct 26, 2020

View reviewed changes

Updates per comments from reviewer.

8fdc35c

TimLovellSmith approved these changes Oct 26, 2020

View reviewed changes

majastrz reviewed Oct 27, 2020

View reviewed changes

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json Show resolved Hide resolved

majastrz reviewed Oct 27, 2020

View reviewed changes

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json Show resolved Hide resolved

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 27, 2020

Remove illegal terminal states from provisioningState. Add new resour…

0ee3fad

…ceState.

Merge branch 'master' into dev-redisenterprise-Microsoft.Cache-2020-1…

7fcae64

…0-01-preview

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Oct 28, 2020

majastrz approved these changes Oct 28, 2020

View reviewed changes

TimLovellSmith mentioned this pull request Oct 28, 2020

Update common types with Operation + OperationListResult #11356

Merged

11 tasks

Utilize common properties from updated v2 types.json

f2430b6

Add 'Deleting' state to ProvisioningState enum.

5307f79

TimLovellSmith approved these changes Oct 28, 2020

View reviewed changes

...senterprise/resource-manager/Microsoft.Cache/preview/2020-10-01-preview/redisenterprise.json Outdated Show resolved Hide resolved

akning-ms merged commit 9abfdcf into Azure:master Oct 29, 2020

greenms mentioned this pull request Nov 11, 2020

Add support for Redis Enterprise. Azure/azure-sdk-for-net#16700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview #11360

[Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview #11360

greenms commented Oct 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 23, 2020 •

edited

Loading

azure-pipelines bot commented Oct 23, 2020

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

azure-pipelines bot commented Oct 23, 2020

greenms commented Oct 23, 2020

azure-pipelines bot commented Oct 23, 2020

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

azure-pipelines bot commented Oct 23, 2020

greenms commented Oct 23, 2020

azure-pipelines bot commented Oct 23, 2020

TimLovellSmith left a comment

azure-pipelines bot commented Oct 26, 2020

TimLovellSmith left a comment

openapi-workflow-bot bot commented Oct 27, 2020

openapi-workflow-bot bot commented Oct 27, 2020

TimLovellSmith commented Oct 28, 2020

majastrz commented Oct 28, 2020

azure-pipelines bot commented Oct 28, 2020

majastrz left a comment

azure-pipelines bot commented Oct 28, 2020

majastrz commented Oct 28, 2020

azure-pipelines bot commented Oct 28, 2020

majastrz commented Oct 28, 2020

greenms commented Oct 28, 2020

[Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview #11360

[Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview #11360

Conversation

greenms commented Oct 23, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Oct 23, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Oct 23, 2020

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-java - Release

azure-pipelines bot commented Oct 23, 2020

greenms commented Oct 23, 2020

azure-pipelines bot commented Oct 23, 2020

openapi-sdkautomation bot commented Oct 23, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Oct 23, 2020

greenms commented Oct 23, 2020

azure-pipelines bot commented Oct 23, 2020

TimLovellSmith left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Oct 26, 2020

TimLovellSmith left a comment

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Oct 27, 2020

openapi-workflow-bot bot commented Oct 27, 2020

TimLovellSmith commented Oct 28, 2020

majastrz commented Oct 28, 2020

azure-pipelines bot commented Oct 28, 2020

majastrz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Oct 28, 2020

majastrz commented Oct 28, 2020

azure-pipelines bot commented Oct 28, 2020

majastrz commented Oct 28, 2020

greenms commented Oct 28, 2020

greenms commented Oct 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 23, 2020 •

edited

Loading