Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for S360 completeness and correctness. #11358

Merged
merged 62 commits into from
Nov 3, 2020
Merged

Fixes for S360 completeness and correctness. #11358

merged 62 commits into from
Nov 3, 2020

Conversation

xolve
Copy link
Contributor

@xolve xolve commented Oct 23, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@xolve xolve added the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Oct 23, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 23, 2020

[Staging] Swagger Validation Report

BreakingChange: 78 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'workspaceNameParameter' removed or renamed?
New: azure-rest-api-specs/blob/ae422cdf31a0d521248c6a8da86335ba0fb9eccc/revision:674:2
Old: azure-rest-api-specs/blob/master/revision:696:2
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'privateLinkHubNameParameter' removed or renamed?
New: azure-rest-api-specs/blob/ae422cdf31a0d521248c6a8da86335ba0fb9eccc/revision:915:2
Old: Microsoft.Synapse/preview/2019-06-01-preview/privatelinkhub.json#L494:3
1008 - ModifiedOperationId The operation id has been changed from 'IntegrationRuntimeObjectMetadata_Get' to 'IntegrationRuntimeObjectMetadata_List'. This will impact generated code.
New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L384:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L384:7
1008 - ModifiedOperationId The operation id has been changed from 'IntegrationRuntimeMonitoringData_Get' to 'IntegrationRuntimeMonitoringData_List'. This will impact generated code.
New: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L953:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L952:7
1010 - AddingRequiredParameter The required parameter 'request' was added in the new version.
New: Microsoft.Synapse/preview/2019-06-01-preview/privateEndpointConnections.json#L83:11
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L50:11
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.Synapse/preview/2019-06-01-preview/operations.json#L47:11
1011 - AddingResponseCode The new version adds a response code '404'.
New: Microsoft.Synapse/preview/2019-06-01-preview/operations.json#L163:11
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.Synapse/preview/2019-06-01-preview/firewallRule.json#L182:11
1011 - AddingResponseCode The new version adds a response code '200'.
New: Microsoft.Synapse/preview/2019-06-01-preview/privateEndpointConnections.json#L143:11
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ae422cd with merge commit 328aeb5. SDK Automation 13.0.17.20200918.2
  • ️✔️preview/synapse/mgmt/2019-06-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 03 Nov 2020 04:14:09 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0700:6BD3:D8221B:234C093:5FA0D911","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 23, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ae422cd with merge commit 328aeb5. SDK Automation 13.0.17.20200918.2
  • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolSensitivityLabelsImpl.java:[60,175] cannot find symbol
      [mvn]   symbol:   class SensitivityLabelSource
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolSensitivityLabelsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[55,159] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[71,119] cannot find symbol
      [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolSensitivityLabelsImpl.java:[60,175] cannot find symbol
      [mvn] [ERROR]   symbol:   class SensitivityLabelSource
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolSensitivityLabelsImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[55,159] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[71,119] cannot find symbol
      [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
      [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
      [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
      [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 03 Nov 2020 04:17:06 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0682:0356:1B425A8:3BB6BD1:5FA0D9C2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 23, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ae422cd with merge commit 328aeb5. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      [npmPack] created ./dist/arm-synapse.js in 920ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-synapse@2.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 682.2kB dist/arm-synapse.js                                                   
      [npmPack] npm notice 258.4kB dist/arm-synapse.min.js                                               
      [npmPack] npm notice 10.4kB  esm/operations/bigDataPools.js                                        
      [npmPack] npm notice 2.5kB   esm/models/bigDataPoolsMappers.js                                     
      [npmPack] npm notice 3.5kB   esm/operations/dataMaskingPolicies.js                                 
      [npmPack] npm notice 2.4kB   esm/models/dataMaskingPoliciesMappers.js                              
      [npmPack] npm notice 3.7kB   esm/operations/dataMaskingRules.js                                    
      [npmPack] npm notice 2.5kB   esm/models/dataMaskingRulesMappers.js                                 
      [npmPack] npm notice 5.8kB   esm/operations/extendedSqlPoolBlobAuditingPolicies.js                 
      [npmPack] npm notice 2.5kB   esm/models/extendedSqlPoolBlobAuditingPoliciesMappers.js              
      [npmPack] npm notice 263B    esm/models/index.js                                                   
      [npmPack] npm notice 2.3kB   esm/operations/index.js                                               
      [npmPack] npm notice 3.7kB   esm/operations/integrationRuntimeAuthKeysOperations.js                
      [npmPack] npm notice 436B    esm/models/integrationRuntimeAuthKeysOperationsMappers.js             
      [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeConnectionInfos.js                   
      [npmPack] npm notice 396B    esm/models/integrationRuntimeConnectionInfosMappers.js                
      [npmPack] npm notice 2.1kB   esm/operations/integrationRuntimeCredentials.js                       
      [npmPack] npm notice 358B    esm/models/integrationRuntimeCredentialsMappers.js                    
      [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeMonitoringDataOperations.js          
      [npmPack] npm notice 443B    esm/models/integrationRuntimeMonitoringDataOperationsMappers.js       
      [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeNodeIpAddressOperations.js           
      [npmPack] npm notice 403B    esm/models/integrationRuntimeNodeIpAddressOperationsMappers.js        
      [npmPack] npm notice 5.0kB   esm/operations/integrationRuntimeNodes.js                             
      [npmPack] npm notice 423B    esm/models/integrationRuntimeNodesMappers.js                          
      [npmPack] npm notice 4.8kB   esm/operations/integrationRuntimeObjectMetadata.js                    
      [npmPack] npm notice 587B    esm/models/integrationRuntimeObjectMetadataMappers.js                 
      [npmPack] npm notice 18.3kB  esm/operations/integrationRuntimes.js                                 
      [npmPack] npm notice 2.8kB   esm/models/integrationRuntimesMappers.js                              
      [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeStatusOperations.js                  
      [npmPack] npm notice 657B    esm/models/integrationRuntimeStatusOperationsMappers.js               
      [npmPack] npm notice 10.9kB  esm/operations/ipFirewallRules.js                                     
      [npmPack] npm notice 2.6kB   esm/models/ipFirewallRulesMappers.js                                  
      [npmPack] npm notice 6.0kB   esm/operations/keys.js                                                
      [npmPack] npm notice 2.5kB   esm/models/keysMappers.js                                             
      [npmPack] npm notice 171.9kB esm/models/mappers.js                                                 
      [npmPack] npm notice 5.0kB   esm/operations/operations.js                                          
      [npmPack] npm notice 669B    esm/models/operationsMappers.js                                       
      [npmPack] npm notice 10.6kB  esm/models/parameters.js                                              
      [npmPack] npm notice 9.2kB   esm/operations/privateEndpointConnections.js                          
      [npmPack] npm notice 2.5kB   esm/models/privateEndpointConnectionsMappers.js                       
      [npmPack] npm notice 3.0kB   esm/operations/privateEndpointConnectionsPrivateLinkHub.js            
      [npmPack] npm notice 2.6kB   esm/models/privateEndpointConnectionsPrivateLinkHubMappers.js         
      [npmPack] npm notice 9.7kB   esm/operations/privateLinkHubs.js                                     
      [npmPack] npm notice 2.5kB   esm/models/privateLinkHubsMappers.js                                  
      [npmPack] npm notice 3.9kB   esm/operations/privateLinkResources.js                                
      [npmPack] npm notice 2.5kB   esm/models/privateLinkResourcesMappers.js                             
      [npmPack] npm notice 3.2kB   esm/operations/restorableDroppedSqlPools.js                           
      [npmPack] npm notice 2.5kB   esm/models/restorableDroppedSqlPoolsMappers.js                        
      [npmPack] npm notice 901B    rollup.config.js                                                      
      [npmPack] npm notice 5.6kB   esm/operations/sqlPoolBlobAuditingPolicies.js                         
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolBlobAuditingPoliciesMappers.js                      
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolColumns.js                                      
      [npmPack] npm notice 2.4kB   esm/models/sqlPoolColumnsMappers.js                                   
      [npmPack] npm notice 2.1kB   esm/operations/sqlPoolConnectionPolicies.js                           
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolConnectionPoliciesMappers.js                        
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolDataWarehouseUserActivities.js                  
      [npmPack] npm notice 2.4kB   esm/models/sqlPoolDataWarehouseUserActivitiesMappers.js               
      [npmPack] npm notice 3.2kB   esm/operations/sqlPoolGeoBackupPolicies.js                            
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolGeoBackupPoliciesMappers.js                         
      [npmPack] npm notice 3.5kB   esm/operations/sqlPoolMetadataSyncConfigs.js                          
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolMetadataSyncConfigsMappers.js                       
      [npmPack] npm notice 2.5kB   esm/operations/sqlPoolOperationResults.js                             
      [npmPack] npm notice 391B    esm/models/sqlPoolOperationResultsMappers.js                          
      [npmPack] npm notice 2.8kB   esm/operations/sqlPoolOperations.js                                   
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolOperationsMappers.js                                
      [npmPack] npm notice 4.0kB   esm/operations/sqlPoolReplicationLinks.js                             
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolReplicationLinksMappers.js                          
      [npmPack] npm notice 7.8kB   esm/operations/sqlPoolRestorePoints.js                                
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolRestorePointsMappers.js                             
      [npmPack] npm notice 15.5kB  esm/operations/sqlPools.js                                            
      [npmPack] npm notice 3.9kB   esm/operations/sqlPoolSchemas.js                                      
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolSchemasMappers.js                                   
      [npmPack] npm notice 5.6kB   esm/operations/sqlPoolSecurityAlertPolicies.js                        
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolSecurityAlertPoliciesMappers.js                     
      [npmPack] npm notice 12.8kB  esm/operations/sqlPoolSensitivityLabels.js                            
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolSensitivityLabelsMappers.js                         
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolsMappers.js                                         
      [npmPack] npm notice 3.1kB   esm/operations/sqlPoolTableColumns.js                                 
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolTableColumnsMappers.js                              
      [npmPack] npm notice 4.2kB   esm/operations/sqlPoolTables.js                                       
      [npmPack] npm notice 2.4kB   esm/models/sqlPoolTablesMappers.js                                    
      [npmPack] npm notice 3.8kB   esm/operations/sqlPoolTransparentDataEncryptions.js                   
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolTransparentDataEncryptionsMappers.js                
      [npmPack] npm notice 2.7kB   esm/operations/sqlPoolUsages.js                                       
      [npmPack] npm notice 419B    esm/models/sqlPoolUsagesMappers.js                                    
      [npmPack] npm notice 5.6kB   esm/operations/sqlPoolVulnerabilityAssessmentRuleBaselines.js         
      [npmPack] npm notice 2.5kB   esm/models/sqlPoolVulnerabilityAssessmentRuleBaselinesMappers.js      

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 23, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ae422cd with merge commit 328aeb5. SDK Automation 13.0.17.20200918.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Synapse [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 03 Nov 2020 04:15:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:7E4A:3712189:5B36690:5FA0D97D","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 23, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ae422cd with merge commit 328aeb5. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-synapse [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-synapse
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-synapse
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 03 Nov 2020 04:11:40 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:42AB:1B40A8E:42BB392:5FA0D87C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 20.131% size of original (original: 144751 chars, delta: 29140 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model WorkspacePatchInfo has a new parameter babylon_configuration
      [ChangeLog]   - Model WorkspacePatchInfo has a new parameter managed_virtual_network_settings
      [ChangeLog]   - Model Workspace has a new parameter workspace_uid
      [ChangeLog]   - Model Workspace has a new parameter encryption
      [ChangeLog]   - Model Workspace has a new parameter babylon_configuration
      [ChangeLog]   - Model Workspace has a new parameter managed_virtual_network_settings
      [ChangeLog]   - Model PrivateLinkHub has a new parameter private_endpoint_connections
      [ChangeLog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter node_communication_channel_encryption_mode
      [ChangeLog]   - Model MetadataSyncConfig has a new parameter sync_interval_in_minutes
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter spark_config_properties
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter session_level_packages_enabled
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter custom_libraries
      [ChangeLog]   - Added operation SqlPoolSchemasOperations.get
      [ChangeLog]   - Added operation SqlPoolVulnerabilityAssessmentRuleBaselinesOperations.get
      [ChangeLog]   - Added operation SqlPoolSecurityAlertPoliciesOperations.list
      [ChangeLog]   - Added operation SqlPoolGeoBackupPoliciesOperations.list
      [ChangeLog]   - Added operation SqlPoolBlobAuditingPoliciesOperations.list_by_sql_pool
      [ChangeLog]   - Added operation IntegrationRuntimesOperations.enable_interactive_query
      [ChangeLog]   - Added operation SqlPoolTablesOperations.get
      [ChangeLog]   - Added operation SqlPoolVulnerabilityAssessmentScansOperations.get
      [ChangeLog]   - Added operation SqlPoolReplicationLinksOperations.get_by_name
      [ChangeLog]   - Added operation SqlPoolSensitivityLabelsOperations.get
      [ChangeLog]   - Added operation IntegrationRuntimeObjectMetadataOperations.list
      [ChangeLog]   - Added operation SqlPoolRestorePointsOperations.get
      [ChangeLog]   - Added operation SqlPoolRestorePointsOperations.delete
      [ChangeLog]   - Added operation IntegrationRuntimeMonitoringDataOperations.list
      [ChangeLog]   - Added operation group RestorableDroppedSqlPoolsOperations
      [ChangeLog]   - Added operation group DataMaskingPoliciesOperations
      [ChangeLog]   - Added operation group ExtendedSqlPoolBlobAuditingPoliciesOperations
      [ChangeLog]   - Added operation group SqlPoolColumnsOperations
      [ChangeLog]   - Added operation group DataMaskingRulesOperations
      [ChangeLog]   - Added operation group KeysOperations
      [ChangeLog]   - Added operation group WorkspaceSqlAadAdminsOperations
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsPrivateLinkHubOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation PrivateEndpointConnectionsOperations.create has a new signature
      [ChangeLog]   - Operation PrivateEndpointConnectionsOperations.create has a new signature
      [ChangeLog]   - Operation SqlPoolMetadataSyncConfigsOperations.create has a new signature
      [ChangeLog]   - Operation PrivateLinkHubsOperations.create_or_update has a new signature
      [ChangeLog]   - Removed operation IntegrationRuntimeObjectMetadataOperations.get
      [ChangeLog]   - Removed operation IntegrationRuntimeMonitoringDataOperations.get

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 23, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 23, 2020

    azure-resource-manager-schemas - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ae422cd with merge commit 328aeb5. Schema Automation 13.0.17.20200918.2
      [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ️✔️synapse [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5802 passing (1m)
        AzureResourceSchema has no registered package commands.
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 03 Nov 2020 04:16:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:729D:32E0709:5805090:5FA0D996","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 23, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      16 similar comments
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @PhoenixHe-NV PhoenixHe-NV merged commit 328aeb5 into Azure:master Nov 3, 2020
      @@ -120,8 +120,11 @@
      },
      "description": "OK"
      },
      "202": {
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Could you please help us understand why you remove this 202 response?

      Copy link
      Contributor Author

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      @aim-for-better Raised PR #11690 for same.

      Copy link
      Contributor

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      @xolve , thanks. but I saw that PR is still a draft? When will that PR be ready for a review?

      Copy link
      Contributor Author

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Updated the PR.

      giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
      * Swagger Correction - First slice
      
      Corrected Swagger based on report from https://aka.ms/LiveValidation
      
      * Removed new line charaters that were being flagged as errors.
      
      Removed new line charaters that were being flagged as errors.
      
      * Fixing attempt for UnhandledPromiseRejectionWarning
      
      Fixing attempt for UnhandledPromiseRejectionWarning
      
      * Removed hopefully all descriptions
      
      * UnhandledPromiseRejectionWarning
      
      * Removed duplicate definition
      
      * Removed duplicate definition
      
      * Removed duplicate definition
      
      * Corrected example.
      
      * Removed nppBackup file.
      
      * Fixes for S360 completeness and correctness.
      
      * Add 200 or 204 responses where DeleteOperationResponses error was flagged.
      
      * Add missing x-ms-azure-resource properties.
      
      * Fix for LongRunningOperationsWithLongRunningExtension error.
      
      * Fix for ListInOperationName.
      
      * Fix LongRunningResponseStatusCode.
      
      * Remove LROStatusCodesReturnTypeSchema.
      
      * Fix PageableOperation.
      
      * Fix PatchInOperationName.
      
      * Added a few descriptions. Disable DescriptionAndTitleMissing check for now.
      
      * Fix AllResourcesMustHaveGetOperation. Supress where not available in SQL Swagger.
      
      * Fixes for NestedResourcesMustHaveListOperation, otherwise excluded.
      
      * Supress IntegerTypeMustHaveFormat since not available in SQL and DataFactory swaggers.
      
      * Remove enum types from fields where its string in source models.
      
      * Add better description.
      
      * Fix PutInOperationName.
      
      * Added suppressions for OperationIdNounConflictingModelNames and GuidUsage.
      
      * Fix AvoidNestedProperties.
      
      * Remove status code from example, not present in spec.
      
      * Remove unreferenced example file.
      
      * Spelling corrections.
      
      * Refactor scopePool to a separate file.
      
      * Remove unused ManagedIdentitySqlControlSettingsModel.
      
      * Added workspace_scopePool.json to readme.md.
      
      * Added GetPrivateEndpointConnectionProxyForPrivateLinkHub.
      
      * Added x-ms-long-running-operation.
      
      * Add sqlAdministrators API.
      
      * Added missing location.
      
      * Fixed IntegerTypeMustHaveFormat,
      
      * Allow for empty classes in generation.
      
      * Prettier fix.
      
      * Remove scope pool APIs.
      
      * Remove keys API specs.
      
      * Removed APIs that need longer code changes for now.
      
      * Removed duplicate api path.
      
      * Fix ErrorContract ref.
      
      * Add integer format.
      
      * Fix merge issues.
      
      * Fix merge issues.
      
      * Fix merge issues.
      
      * Revert unrealted change.
      
      * Remove x-ms-long-running-operation causing error on Java SDK.
      
      * Revert refactor of managed identity.
      
      * Prettier fix.
      
      * Remove x-ms-azure-resource tag.
      
      * Remove x-ms-azure-resource tag.
      
      * Remove x-ms-azure-resource tag.
      
      * Removed temporarily supressed warnings.
      
      * Remove changes for data-plane.
      
      * Fix bad merge.
      
      * Remove changes for print endpoint connection proxies.
      
      * Remove extraneous x-ms-azure-resource tags added.
      
      Co-authored-by: Amogh Natu <amnat@microsoft.com>
      Co-authored-by: Ravi Arora <raviarora@microsoft.com>
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      6 participants