-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for S360 completeness and correctness. #11358
Conversation
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
16 similar comments
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...ynapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -120,8 +120,11 @@ | |||
}, | |||
"description": "OK" | |||
}, | |||
"202": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please help us understand why you remove this 202 response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aim-for-better Raised PR #11690 for same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xolve , thanks. but I saw that PR is still a draft? When will that PR be ready for a review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the PR.
* Swagger Correction - First slice Corrected Swagger based on report from https://aka.ms/LiveValidation * Removed new line charaters that were being flagged as errors. Removed new line charaters that were being flagged as errors. * Fixing attempt for UnhandledPromiseRejectionWarning Fixing attempt for UnhandledPromiseRejectionWarning * Removed hopefully all descriptions * UnhandledPromiseRejectionWarning * Removed duplicate definition * Removed duplicate definition * Removed duplicate definition * Corrected example. * Removed nppBackup file. * Fixes for S360 completeness and correctness. * Add 200 or 204 responses where DeleteOperationResponses error was flagged. * Add missing x-ms-azure-resource properties. * Fix for LongRunningOperationsWithLongRunningExtension error. * Fix for ListInOperationName. * Fix LongRunningResponseStatusCode. * Remove LROStatusCodesReturnTypeSchema. * Fix PageableOperation. * Fix PatchInOperationName. * Added a few descriptions. Disable DescriptionAndTitleMissing check for now. * Fix AllResourcesMustHaveGetOperation. Supress where not available in SQL Swagger. * Fixes for NestedResourcesMustHaveListOperation, otherwise excluded. * Supress IntegerTypeMustHaveFormat since not available in SQL and DataFactory swaggers. * Remove enum types from fields where its string in source models. * Add better description. * Fix PutInOperationName. * Added suppressions for OperationIdNounConflictingModelNames and GuidUsage. * Fix AvoidNestedProperties. * Remove status code from example, not present in spec. * Remove unreferenced example file. * Spelling corrections. * Refactor scopePool to a separate file. * Remove unused ManagedIdentitySqlControlSettingsModel. * Added workspace_scopePool.json to readme.md. * Added GetPrivateEndpointConnectionProxyForPrivateLinkHub. * Added x-ms-long-running-operation. * Add sqlAdministrators API. * Added missing location. * Fixed IntegerTypeMustHaveFormat, * Allow for empty classes in generation. * Prettier fix. * Remove scope pool APIs. * Remove keys API specs. * Removed APIs that need longer code changes for now. * Removed duplicate api path. * Fix ErrorContract ref. * Add integer format. * Fix merge issues. * Fix merge issues. * Fix merge issues. * Revert unrealted change. * Remove x-ms-long-running-operation causing error on Java SDK. * Revert refactor of managed identity. * Prettier fix. * Remove x-ms-azure-resource tag. * Remove x-ms-azure-resource tag. * Remove x-ms-azure-resource tag. * Removed temporarily supressed warnings. * Remove changes for data-plane. * Fix bad merge. * Remove changes for print endpoint connection proxies. * Remove extraneous x-ms-azure-resource tags added. Co-authored-by: Amogh Natu <amnat@microsoft.com> Co-authored-by: Ravi Arora <raviarora@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.