Added api-version 2020-10-20 to Microsoft.Insights #11307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: type New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L511 |
|
| Based on the response model schema, operation 'ComponentCurrentBillingFeatures_Get' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json#L38 |
|
| Based on the response model schema, operation 'ComponentAvailableFeatures_Get' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json#L177 |
|
| The tracked resource, 'Workbook', must have a list by subscriptions operation. New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L349 |
|
| 'Properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L269 |
|
| 'userAssignedIdentities' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L508 |
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️⚠️~[Staging] Cross Version BreakingChange (Base on preview version): 2 Warnings warning [Detail] [Expand]
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2018-06-17-preview/workbookOperations_API.json <---> new: stable/2020-10-20/workbookOperations_API.json
- original: preview/2018-06-17-preview/workbooks_API.json <---> new: stable/2020-10-20/workbooks_API.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' removed or restructured? New: azure-rest-api-specs/blob/6e87f22b77364306c59a5fb2a1c2a38f55f0c387/ Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L37:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' removed or restructured? New: azure-rest-api-specs/blob/6e87f22b77364306c59a5fb2a1c2a38f55f0c387/ Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L88:5 |
️⚠️~[Staging] Cross Version BreakingChange (Base on stable version): 19 Warnings warning [Detail] [Expand]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2015-05-01/myworkbooks_API.json <---> new: stable/2020-10-20/myworkbooks_API.json
- original: stable/2015-05-01/workbooks_API.json <---> new: stable/2020-10-20/workbooks_API.json
| Rule | Message |
|---|---|
| The new version is missing a client parameter that was found in the old version. Was 'ResourceIdParameter' removed or renamed? New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L537:3 Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L458:3 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L349:5 Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L309:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Insights/stable/2020-10-20/workbooks_API.json#L341:11 Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L301:11 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' removed or restructured? New: azure-rest-api-specs/blob/6e87f22b77364306c59a5fb2a1c2a38f55f0c387/ Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks' removed or restructured? New: azure-rest-api-specs/blob/6e87f22b77364306c59a5fb2a1c2a38f55f0c387/ Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37:5 |
|
Hi, @tonykslee Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
This was referenced Oct 20, 2020
This was referenced Oct 20, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akning-ms
approved these changes
Nov 5, 2020
|
About how long does it take for these changes to be seen in Azure alias validations and such? |
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* added new folder for swagger api version * updated api with current request/responses * updated api version * updated readme * fixed typo * added operation list * added error to operation list * removed redundant files * removed operations operation from workbooks_api * added api version parameters * added references to the new examples * removed delete since it didn't change from the last api version * added new operations api file for compatibility * fixing lint errors * fix lint errors * fixing model errors * model errors * fixing modeling errors * fixing model errors * fixing model errors * fixing model errors * fix model errors * fix model errors * fix model errors * ran prettier * lint error added delete example * lint error added delete example * added unreferenced json files * fixed model errors * fixed model errors * removed operations from readme * updated examples * resolving lint, avocado, prettier issues * updated workbook operations api * changed operation path * removed aiOperatrions from new api version * udpated workbook operations name * pascal case path names * added myworkbooks * added exclusions * updated exclusions to be more specific * added exclusion and updated operations path * updated operations path * Revert "updated operations path" This reverts commit 832f2f0. * changed operations path case * Revert "changed operations path case" This reverts commit da50e81. * replaced all lowercase microsoft.insights with Pascal Case * Revert "replaced all lowercase microsoft.insights with Pascal Case" This reverts commit 6d9a19a. * replaced all lowercase microsoft.insights with Pascal Case * added another exclusijon for webtests default responses * added exclusion for OperationsAPIImplementation * updated suppression * using existing Identity Definition * remove CDN references from Operations API file * added errorResponse type object in operations api * update to use existing common type * ran prettier * added enum values to identity types in types.json * removed use of common type for identity * updated identity schema * updated identity schema * updated identity schema * updated identity schema * updated identity schema * ran prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.