Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling archival and unarchival of a reservation. #11246

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Conversation

sornaks
Copy link
Contributor

@sornaks sornaks commented Oct 16, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 16, 2020

[Staging] Swagger Validation Report

BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1026 - TypeChanged The new version has a different type 'object' than the previous one 'array'.
New: Microsoft.Capacity/preview/2019-04-01/reservations.json#L41:9
Old: Microsoft.Capacity/preview/2019-04-01/reservations.json#L41:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-workflow-bot
Copy link

Hi, @sornaks Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2020
    @openapi-workflow-bot
    Copy link

    Hi, @sornaks your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from f6af652 with merge commit 2b96e78. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-reservations [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/azureReservationAPI.js → ./dist/arm-reservations.js...
      [npmPack] created ./dist/arm-reservations.js in 464ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-reservations@5.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 170.9kB dist/arm-reservations.js                     
      [npmPack] npm notice 59.7kB  dist/arm-reservations.min.js                 
      [npmPack] npm notice 2.8kB   esm/operations/autoQuotaIncrease.js          
      [npmPack] npm notice 1.1kB   esm/models/autoQuotaIncreaseMappers.js       
      [npmPack] npm notice 4.0kB   esm/azureReservationAPI.js                   
      [npmPack] npm notice 2.1kB   esm/azureReservationAPIContext.js            
      [npmPack] npm notice 2.9kB   esm/operations/calculateExchange.js          
      [npmPack] npm notice 815B    esm/models/calculateExchangeMappers.js       
      [npmPack] npm notice 2.7kB   esm/operations/exchange.js                   
      [npmPack] npm notice 612B    esm/models/exchangeMappers.js                
      [npmPack] npm notice 263B    esm/models/index.js                          
      [npmPack] npm notice 527B    esm/operations/index.js                      
      [npmPack] npm notice 78.5kB  esm/models/mappers.js                        
      [npmPack] npm notice 2.2kB   esm/operations/operation.js                  
      [npmPack] npm notice 393B    esm/models/operationMappers.js               
      [npmPack] npm notice 4.1kB   esm/models/parameters.js                     
      [npmPack] npm notice 11.5kB  esm/operations/quota.js                      
      [npmPack] npm notice 1.1kB   esm/models/quotaMappers.js                   
      [npmPack] npm notice 3.9kB   esm/operations/quotaRequestStatus.js         
      [npmPack] npm notice 1.1kB   esm/models/quotaRequestStatusMappers.js      
      [npmPack] npm notice 14.2kB  esm/operations/reservation.js                
      [npmPack] npm notice 1.3kB   esm/models/reservationMappers.js             
      [npmPack] npm notice 6.0kB   esm/operations/reservationOrder.js           
      [npmPack] npm notice 1.2kB   esm/models/reservationOrderMappers.js        
      [npmPack] npm notice 907B    rollup.config.js                             
      [npmPack] npm notice 1.7kB   package.json                                 
      [npmPack] npm notice 457B    tsconfig.json                                
      [npmPack] npm notice 310.5kB dist/arm-reservations.js.map                 
      [npmPack] npm notice 47.3kB  dist/arm-reservations.min.js.map             
      [npmPack] npm notice 1.2kB   esm/operations/autoQuotaIncrease.d.ts.map    
      [npmPack] npm notice 1.6kB   esm/operations/autoQuotaIncrease.js.map      
      [npmPack] npm notice 586B    esm/models/autoQuotaIncreaseMappers.d.ts.map 
      [npmPack] npm notice 599B    esm/models/autoQuotaIncreaseMappers.js.map   
      [npmPack] npm notice 1.7kB   esm/azureReservationAPI.d.ts.map             
      [npmPack] npm notice 2.5kB   esm/azureReservationAPI.js.map               
      [npmPack] npm notice 426B    esm/azureReservationAPIContext.d.ts.map      
      [npmPack] npm notice 1.2kB   esm/azureReservationAPIContext.js.map        
      [npmPack] npm notice 670B    esm/operations/calculateExchange.d.ts.map    
      [npmPack] npm notice 1.4kB   esm/operations/calculateExchange.js.map      
      [npmPack] npm notice 428B    esm/models/calculateExchangeMappers.d.ts.map 
      [npmPack] npm notice 441B    esm/models/calculateExchangeMappers.js.map   
      [npmPack] npm notice 646B    esm/operations/exchange.d.ts.map             
      [npmPack] npm notice 1.3kB   esm/operations/exchange.js.map               
      [npmPack] npm notice 338B    esm/models/exchangeMappers.d.ts.map          
      [npmPack] npm notice 351B    esm/models/exchangeMappers.js.map            
      [npmPack] npm notice 25.1kB  esm/models/index.d.ts.map                    
      [npmPack] npm notice 292B    esm/operations/index.d.ts.map                
      [npmPack] npm notice 126B    esm/models/index.js.map                      
      [npmPack] npm notice 306B    esm/operations/index.js.map                  
      [npmPack] npm notice 4.4kB   esm/models/mappers.d.ts.map                  
      [npmPack] npm notice 43.3kB  esm/models/mappers.js.map                    
      [npmPack] npm notice 1.0kB   esm/operations/operation.d.ts.map            
      [npmPack] npm notice 1.4kB   esm/operations/operation.js.map              
      [npmPack] npm notice 226B    esm/models/operationMappers.d.ts.map         
      [npmPack] npm notice 239B    esm/models/operationMappers.js.map           
      [npmPack] npm notice 1.0kB   esm/models/parameters.d.ts.map               
      [npmPack] npm notice 3.3kB   esm/models/parameters.js.map                 
      [npmPack] npm notice 2.7kB   esm/operations/quota.d.ts.map                
      [npmPack] npm notice 4.8kB   esm/operations/quota.js.map                  
      [npmPack] npm notice 608B    esm/models/quotaMappers.d.ts.map             
      [npmPack] npm notice 621B    esm/models/quotaMappers.js.map               
      [npmPack] npm notice 1.8kB   esm/operations/quotaRequestStatus.d.ts.map   
      [npmPack] npm notice 2.4kB   esm/operations/quotaRequestStatus.js.map     
      [npmPack] npm notice 601B    esm/models/quotaRequestStatusMappers.d.ts.map
      [npmPack] npm notice 614B    esm/models/quotaRequestStatusMappers.js.map  
      [npmPack] npm notice 3.7kB   esm/operations/reservation.d.ts.map          
      [npmPack] npm notice 7.2kB   esm/operations/reservation.js.map            
      [npmPack] npm notice 676B    esm/models/reservationMappers.d.ts.map       
      [npmPack] npm notice 689B    esm/models/reservationMappers.js.map         
      [npmPack] npm notice 2.2kB   esm/operations/reservationOrder.d.ts.map     
      [npmPack] npm notice 3.5kB   esm/operations/reservationOrder.js.map       
      [npmPack] npm notice 636B    esm/models/reservationOrderMappers.d.ts.map  
      [npmPack] npm notice 649B    esm/models/reservationOrderMappers.js.map    
      [npmPack] npm notice 3.6kB   README.md                                    
      [npmPack] npm notice 2.7kB   esm/operations/autoQuotaIncrease.d.ts        
      [npmPack] npm notice 5.3kB   src/operations/autoQuotaIncrease.ts          
      [npmPack] npm notice 852B    esm/models/autoQuotaIncreaseMappers.d.ts     
      [npmPack] npm notice 1.1kB   src/models/autoQuotaIncreaseMappers.ts       
      [npmPack] npm notice 3.6kB   esm/azureReservationAPI.d.ts                 
      [npmPack] npm notice 6.5kB   src/azureReservationAPI.ts                   
      [npmPack] npm notice 653B    esm/azureReservationAPIContext.d.ts          
      [npmPack] npm notice 1.9kB   src/azureReservationAPIContext.ts            
      [npmPack] npm notice 1.6kB   esm/operations/calculateExchange.d.ts        
      [npmPack] npm notice 3.0kB   src/operations/calculateExchange.ts          
      [npmPack] npm notice 587B    esm/models/calculateExchangeMappers.d.ts     
      [npmPack] npm notice 804B    src/models/calculateExchangeMappers.ts       
      [npmPack] npm notice 1.4kB   esm/operations/exchange.d.ts                 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from f6af652 with merge commit 2b96e78. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-reservations [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-reservations
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-reservations
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 20.615% size of original (original: 45385 chars, delta: 9356 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Added operation group CalculateExchangeOperations
      [ChangeLog]   - Added operation group ExchangeOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation ReservationOperations.available_scopes has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 16, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from f6af652 with merge commit 2b96e78. Schema Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ravbhatnagar
    Copy link
    Contributor

    Signing off from ARM side. just one minor note.

    @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2020
    @sornaks
    Copy link
    Contributor Author

    sornaks commented Oct 16, 2020

    Thank you for the approval. As discussed, this is not a breaking change. The original schema for ScopeParameter was incorrect. It was never shipped that way. If someone had made a call with ScopeParameter following the original schema they would have received a 400. With the new tooling, we were able to identify this issue. Thus fixing it now. Discussed the same with the ARM team over a call and they had approved it. Could you please skip the Breaking Change merge validation and complete the PR?

    @bterlson
    Copy link
    Member

    This breaking change rationale makes sense to me (i.e. that it's not really a breaking change)!

    @openapi-workflow-bot
    Copy link

    Hi @sornaks, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

    @sornaks
    Copy link
    Contributor Author

    sornaks commented Oct 20, 2020

    Breaking change was approved. Reference work item: https://msazure.visualstudio.com/One/_workitems/edit/8629781

    @JeffreyRichter JeffreyRichter self-requested a review October 20, 2020 21:03
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 20, 2020
    @jianyexi
    Copy link
    Contributor

    hi @changlong-liu could you take a look at Python SDK Breaking change?

    @sornaks
    Copy link
    Contributor Author

    sornaks commented Oct 28, 2020

    hi @jianyexi is there any update on this? When should we expect this to be merged?

    @jianyexi
    Copy link
    Contributor

    hi @jianyexi is there any update on this? When should we expect this to be merged?

    Is the Python SDK breaking change caused by this PR ?

    @sornaks
    Copy link
    Contributor Author

    sornaks commented Oct 29, 2020

    hi @jianyexi is there any update on this? When should we expect this to be merged?

    Is the Python SDK breaking change caused by this PR ?

    The python build on this particular PR has succeeded - where are you seeing that it is broken?

    @jianyexi
    Copy link
    Contributor

    jianyexi commented Oct 29, 2020

    hi @jianyexi is there any update on this? When should we expect this to be merged?

    Is the Python SDK breaking change caused by this PR ?

    The python build on this particular PR has succeeded - where are you seeing that it is broken?
    I mean this check has a warning for SDK breaking change :
    #11246 (comment)

    @jianyexi
    Copy link
    Contributor

    @sornaks pls resolve the conflict

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sornaks
    Copy link
    Contributor Author

    sornaks commented Oct 29, 2020

    @sornaks pls resolve the conflict

    Have resolved the conflict. @jianyexi could you please merge?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jianyexi
    Copy link
    Contributor

    As breaking change has been approved, merged

    @jianyexi jianyexi merged commit 2b96e78 into master Oct 30, 2020
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    Co-authored-by: Sornakumar Sundararajan <sornaks@microsoft.com>
    @JackTn JackTn deleted the sornaks/archive branch August 9, 2021 10:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants