-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling archival and unarchival of a reservation. #11246
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1026 - TypeChanged |
The new version has a different type 'object' than the previous one 'array'. New: Microsoft.Capacity/preview/2019-04-01/reservations.json#L41:9 Old: Microsoft.Capacity/preview/2019-04-01/reservations.json#L41:9 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @sornaks Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Hi, @sornaks your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
b5433d0
to
ab2d73b
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
...reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/GetCatalog.json
Outdated
Show resolved
Hide resolved
ab2d73b
to
6286e53
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
...source-manager/Microsoft.Capacity/preview/2019-04-01/examples/CalculateReservationOrder.json
Outdated
Show resolved
Hide resolved
6286e53
to
7c35819
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
7c35819
to
ef2212c
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
ef2212c
to
78504ff
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
4dcf1f6
to
b14abd9
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Signing off from ARM side. just one minor note. |
...cation/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json
Show resolved
Hide resolved
Thank you for the approval. As discussed, this is not a breaking change. The original schema for |
This breaking change rationale makes sense to me (i.e. that it's not really a breaking change)! |
Hi @sornaks, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Breaking change was approved. Reference work item: https://msazure.visualstudio.com/One/_workitems/edit/8629781 |
hi @changlong-liu could you take a look at Python SDK Breaking change? |
hi @jianyexi is there any update on this? When should we expect this to be merged? |
Is the Python SDK breaking change caused by this PR ? |
The python build on this particular PR has succeeded - where are you seeing that it is broken? |
|
@sornaks pls resolve the conflict |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
As breaking change has been approved, merged |
Co-authored-by: Sornakumar Sundararajan <sornaks@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.