Enabling the creation of JavaScript SDK for the Communication resource manager #11114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
weidongxu-microsoft
approved these changes
Oct 10, 2020
qiaozha
reviewed
Oct 10, 2020
| @@ -53,6 +53,7 @@ swagger-to-sdk: | |||
| - repo: azure-sdk-for-python | |||
| - repo: azure-sdk-for-python-track2 | |||
| - repo: azure-sdk-for-go | |||
| - repo: azure-sdk-for-js | |||
| after_scripts: | |||
| - bundle install && rake arm:regen_all_profiles['azure_mgmt_vsonline'] | |||
There was a problem hiding this comment.
JS SDK doesn't have after scripts, you should remove the after scripts or put it right after the repo that needs it. #Resolved
There was a problem hiding this comment.
Good catch. That after_script is not needed. I'll remove it. #Resolved
qiaozha
reviewed
Oct 10, 2020
| typescript: | ||
| azure-arm: true | ||
| package-name: "@azure/arm-communication" | ||
| output-folder: "$(typescript-sdks-folder)/sdk/communication/arm-communication" |
There was a problem hiding this comment.
I just found that the folder https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication is not empty, Are those the communication data-plane SDKs? #Resolved
There was a problem hiding this comment.
Correct. Those are the data-plane SDKs. #Resolved
qiaozha
reviewed
Oct 10, 2020
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-resource-manager-schemas - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
|
This was referenced Oct 13, 2020
This was referenced Oct 13, 2020
qiaozha
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the creation of JavaScript SDK for the Communication resource manager.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.