[Data Factory] set computeType, coreCount to object type to allow expressions #10897
+4
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version has a different type 'object' than the previous one 'string'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 |
|
The new version has a different type 'object' than the previous one 'integer'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6841:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6850:13 |
|
The new version has a different type 'object' than the previous one 'string'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6837:13 |
|
The new version has a different type 'object' than the previous one 'integer'. New: stable/2018-06-01/entityTypes/Pipeline.json#L6841:13 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6850:13 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 22, 2020
|
We would like to support both object and string type for |
|
@qianwens could you please review this change? |
qianwens
reviewed
Sep 25, 2020
| @@ -6835,21 +6835,12 @@ | |||
| "type": "object", | |||
| "properties": { | |||
| "computeType": { | |||
| "description": "Compute type of the cluster which will execute data flow job.", | |||
| "type": "string", | |||
| "enum": [ | |||
There was a problem hiding this comment.
This would cause breaking change in SDK. Please request an approval from API Review Board as defined in the Breaking Change Policy.
There was a problem hiding this comment.
@qianwens This is actually a bug that we are trying to fix. I agree that customers may have to update their code if they are relying on the string data type for these two properties, and the change required would be a simple cast to string type. But this is still a bug and we are not able to support expressions for these two properties as they are currently modeled as string. Also, we do have some customers waiting on the expression support. Given this, do we still need to get approval from API Review Board?
JeffreyRichter
approved these changes
Nov 4, 2020
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…#10897) Co-authored-by: Bhaskar Annamalai <bhaskara@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.