add required fields for sku object #10623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforPostgreSQL/servers/{serverName}/virtualNetworkRules' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2017-12-01-preview/postgresql.json#L691:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBforMySQL/servers' removed or restructured? Old: Microsoft.DBforMySQL/preview/2018-06-01-privatepreview/mysql.json#L256:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/firewallRules' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L507:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/virtualNetworkRules/{virtualNetworkRuleName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L546:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/virtualNetworkRules' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L691:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/databases/{databaseName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L733:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/databases' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L869:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/configurations/{configurationName}' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L908:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/configurations' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L997:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMariaDB/servers/{serverName}/logFiles' removed or restructured? Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1036:5 |
️❌LintDiff: 2 Errors, 0 Warnings [Detail] [Expand]
❌| Rule | Message |
|---|---|
|
"details":" "Channel": "fatal", "Text": "swagger-document/compose - FAILED" "Channel": "fatal", "Text": "Error: '$.definitions.ProxyResource.description' has incompatible values (---\nResource properties.\n, ---\nARM proxy resource.\n)."(node:8761) UnhandledPromiseRejectionWarning: Error: '$.definitions.ProxyResource.description' has incompatible values (---Resource properties.", "location":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/mariadb/resource-manager/readme.md" |
|
"details":" "Channel": "fatal", "Text": "swagger-document/compose - FAILED" "Channel": "fatal", "Text": "Error: '$.definitions.ProxyResource.description' has incompatible values (---\nResource properties.\n, ---\nARM proxy resource.\n)."(node:10198) UnhandledPromiseRejectionWarning: Error: '$.definitions.ProxyResource.description' has incompatible values (---Resource properties.", "location":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/mysql/resource-manager/readme.md" |
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Aug 27, 2020
This was referenced Aug 27, 2020
This was referenced Sep 1, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The lintDiff errors are existing errors in the master branch , so the tool always fails Based on the result running lint locally , the PR has no new lint errors now ,so these errors can be ignored.: |
|
@raych1 , based on jianyexi's comments above, can we get this merged? |
Got it, thanks @QingqingYuan2. Hi @akning-ms, this PR is read to merge, could you help force merge this PR? |
|
@changlong-liu @ArcturusZhang @weidongxu-microsoft for comments SDK breaking change impact. |
|
Java SDK on these are all beta, so should be fine. Require "name" on "sku" is reasonable. One change happens to stable |
This change has been approved by "Azure Services Breaking Changes Reviewers ". To summarize and close down this thread:
|
|
For Python, this breaking change will raise SDK major version. |
|
Go SDK is always OK with breaking changes. |
|
Python SDK, we will release one version in next week anyway with our new offering. For CLI, sku.name also already a required field. As the PR indicates, there is no breaking change from API behavior. This is to fix the Swagger only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required fields already enforced from RP side from first day, but missed the tag in Swagger. Adding this tag to ensure customer aware of this requirement before submitting to RP and receiving provisioning errors later.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.