Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating Form Recognizer V2.0 to stable #10367

Merged
merged 2 commits into from
Aug 6, 2020
Merged

updating Form Recognizer V2.0 to stable #10367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a04c7
updating FR V2.0 to stable
kristapratico Aug 6, 2020
89b1940
remove old tags
kristapratico Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions specification/cognitiveservices/data-plane/FormRecognizer/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ openapi-type: data-plane

``` yaml

tag: release_2_0_preview
Copy link
Member

@samvaity samvaity Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be release_2_0_GA and also other references below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this entire new block is not necessary (line 18 to 24)

Copy link
Member Author

@kristapratico kristapratico Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the collapsed tag above, that one targets GA and is just release_2_0 (sorry the diff is confusing)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following Text Analytics format where preview releases have preview tagged on it and GA releases do not: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/cognitiveservices/data-plane/TextAnalytics#releases

Copy link
Member Author

@kristapratico kristapratico Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see your comment @lmazuel - do we not want to allow generation of the 2.0-preview as an option?

add-credentials: true
openapi-type: data-plane
```

``` yaml

tag: release_1_0
add-credentials: true
openapi-type: data-plane
Expand All @@ -25,10 +32,19 @@ openapi-type: data-plane
These settings apply only when `--tag=release_2_0` is specified on the command line.

``` yaml $(tag) == 'release_2_0'
input-file:
- stable/v2.0/FormRecognizer.json
```

### Release 2.0-preview
These settings apply only when `--tag=release_2_0_preview` is specified on the command line.

``` yaml $(tag) == 'release_2_0_preview'
input-file:
- preview/v2.0/FormRecognizer.json
```


### Release 1.0
These settings apply only when `--tag=release_1_0` is specified on the command line.

Expand Down Expand Up @@ -101,6 +117,7 @@ require: $(this-folder)/../../../../profiles/readme.md

# all the input files across all versions
input-file:
- $(this-folder)/stable/v2.0/FormRecognizer.json
- $(this-folder)/preview/v2.0/FormRecognizer.json
- $(this-folder)/preview/v1.0/FormRecognizer.json
- $(this-folder)/preview/v1.0/FormRecognizerReceipt.json
Expand Down
Loading