Mofnmodel #10195

vasanthrajams · 2020-07-17T23:37:56Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

* Adding 7.2-preview version Signed-off-by: vasanthrajams <vasanthrajams@microsoft.com> * Resolve PR feedback * Fix output-folder for go code generation Co-authored-by: Heath Stewart <heaths@outlook.com>

This change modifies the number of certificates(containing public keys) customer needs to provide for encrypting the security domain to a M of N model. In this model, customer specifies the M certificates out of N certificates needed to restore the security domain. Signed-off-by: vasanthrajams <vasanthrajams@microsoft.com>

openapi-pipeline-app · 2020-07-17T23:38:00Z

[Staging] Swagger Validation Report

️❌BreakingChange: 19 Errors, 0 Warnings [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CertificateSet' removed or renamed? New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L187:3 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L187:3
`❌` 1009 - RemovedRequiredParameter	The required parameter 'Certificates' was removed in the new version. Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L38:11
`❌` 1010 - AddingRequiredParameter	The required parameter 'CertificateInfoObject' was added in the new version. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L38:11
`❌` 1026 - TypeChanged	The new version has a different type 'object' than the previous one 'string'. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L431:9 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L228:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L240:7 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L227:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L240:7 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L227:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'EncData' that was not found in the old version. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L433:11
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'data' that was not found in the old version. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L240:7 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L227:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'alg' that was not found in the old version. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L230:9 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L218:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'alg' that was not found in the old version. New: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L369:5 Old: Microsoft.KeyVault/preview/7.2-preview/securitydomain.json#L253:5

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-17T23:38:13Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-17T23:39:31Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from b74f987 with merge commit 23a83bf. SDK Automation 13.0.17.20200828.8

[AutoRest] FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.KeyVault/stable/7.1/certificates.json, Microsoft.KeyVault/stable/7.1/common.json, Microsoft.KeyVault/stable/7.1/keys.json, Microsoft.KeyVault/stable/7.1/secrets.json, Microsoft.KeyVault/stable/7.1/storage.json
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest] Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.153 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/keyvault/data-plane/readme.md FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.KeyVault/stable/7.1/certificates.json, Microsoft.KeyVault/stable/7.1/common.json, Microsoft.KeyVault/stable/7.1/keys.json, Microsoft.KeyVault/stable/7.1/secrets.json, Microsoft.KeyVault/stable/7.1/storage.json
   at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-07-17T23:39:32Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-17T23:39:37Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-17T23:39:37Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-17T23:39:37Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-17T23:39:40Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-17T23:39:56Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-07-18T00:01:41Z

Can one of the admins verify this patch?

azure-pipelines · 2020-07-31T02:15:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-07T20:51:16Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-27T20:00:50Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-27T20:03:54Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

dcleblanc

There would never be 2 pstore elements, there would be one pstore, and one for the partition backup.

amitbapat

Please include min and max limits in the description, so that auto-generated REST API doc looks good.

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/securitydomain.json

azure-pipelines · 2020-08-28T03:13:41Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-28T03:23:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-28T03:25:47Z

Azure Pipelines successfully started running 1 pipeline(s).

dcleblanc

This sample is incorrect, not the same as the actual JSON

azure-pipelines · 2020-08-29T01:18:18Z

No commit pushedDate could be found for PR 10195 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-08-29T01:21:37Z

Azure Pipelines successfully started running 1 pipeline(s).

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/securitydomain.json

vasanthrajams and others added 14 commits March 5, 2020 18:20

Adding 7.2-preview version (#8397)

3a50214

* Adding 7.2-preview version Signed-off-by: vasanthrajams <vasanthrajams@microsoft.com> * Resolve PR feedback * Fix output-folder for go code generation Co-authored-by: Heath Stewart <heaths@outlook.com>

Merge branch 'dev-keyvault-Microsoft.KeyVault-7.2'

4b6ab61

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

4abcda2

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

29f5dea

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

78c3398

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

af41d9a

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

23a6d0f

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

5f09ae9

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

c2d80d3

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

b9e4b30

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

657170d

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

2c181b4

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

02820bd

vasanthrajams requested review from vickm, docschmidt and amitbapat July 17, 2020 23:37

openapi-assignment-bot bot assigned anuchandy Jul 17, 2020

vasanthrajams added 2 commits July 22, 2020 17:01

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

3032874

Merge branch 'master' into mofnmodel

3283fac

security domain id

d94d796

heaths approved these changes Aug 8, 2020

View reviewed changes

Removing Security Domain ID

4170164

dcleblanc reviewed Aug 27, 2020

View reviewed changes

amitbapat suggested changes Aug 27, 2020

View reviewed changes

Fixed a few more specs

8369318

model validation failures

711cb9f

pretty check

0d001cb

dcleblanc reviewed Aug 28, 2020

View reviewed changes

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 29, 2020

vasanthrajams added 3 commits August 28, 2020 18:14

changed tag

ffb7adb

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

c986ef2

Merge branch 'master' into mofnmodel

1014097

tag change

b74f987

dcleblanc approved these changes Aug 29, 2020

View reviewed changes

vasanthrajams marked this pull request as ready for review August 29, 2020 01:50

anuchandy approved these changes Aug 31, 2020

View reviewed changes

heaths approved these changes Aug 31, 2020

View reviewed changes

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/securitydomain.json Show resolved Hide resolved

specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2-preview/securitydomain.json Show resolved Hide resolved

anuchandy added the potential-sdk-breaking-change label Sep 1, 2020

lmazuel merged commit 23a83bf into master Sep 1, 2020

lmazuel deleted the mofnmodel branch September 1, 2020 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mofnmodel #10195

Mofnmodel #10195

vasanthrajams commented Jul 17, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 17, 2020 •

edited

Loading

azure-pipelines bot commented Jul 17, 2020

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

azuresdkci commented Jul 18, 2020

azure-pipelines bot commented Jul 31, 2020

azure-pipelines bot commented Aug 7, 2020

azure-pipelines bot commented Aug 27, 2020

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading

dcleblanc left a comment

amitbapat left a comment

azure-pipelines bot commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

dcleblanc left a comment

azure-pipelines bot commented Aug 29, 2020

azure-pipelines bot commented Aug 29, 2020

Mofnmodel #10195

Mofnmodel #10195

Conversation

vasanthrajams commented Jul 17, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jul 17, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 17, 2020

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 17, 2020 • edited Loading

azure-sdk-for-java - Release

azuresdkci commented Jul 18, 2020

azure-pipelines bot commented Jul 31, 2020

azure-pipelines bot commented Aug 7, 2020

azure-pipelines bot commented Aug 27, 2020

openapi-sdkautomation bot commented Aug 27, 2020 • edited Loading

azure-resource-manager-schemas - Release

dcleblanc left a comment

Choose a reason for hiding this comment

amitbapat left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

dcleblanc left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Aug 29, 2020

azure-pipelines bot commented Aug 29, 2020

vasanthrajams commented Jul 17, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 17, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 27, 2020 •

edited

Loading