Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make origin a ProxyResource instead of TrackedResource #10126

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Make origin a ProxyResource instead of TrackedResource #10126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcee227
Make origin a ProxyResource instead of TrackedResource
nachakra Jul 14, 2020
c01f2ca
Fix model validation error
nachakra Jul 14, 2020
c715e31
Fix model validation errors
nachakra Jul 14, 2020
f1d46c2
Fix prettier errors
nachakra Jul 14, 2020
0b0aca5
Make origin a proxyresource for all API versions starting from 12-30-…
nachakra Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2019-12-31/cdn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4332,7 +4332,7 @@
"type": "object",
"allOf": [
{
"$ref": "#/definitions/TrackedResource"
"$ref": "#/definitions/ProxyResource"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I know why have this change from business/service perspective? as it is a breaking change for a stable api version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have always been a proxy resource - it is associated with an endpoint which is a tracked resource. We don't need location/tags for this resource. As I said, this API version and the ones following it are not released as yet.

}
],
"properties": {
Expand Down Expand Up @@ -4378,13 +4378,6 @@
"type": "object",
"description": "Origin properties needed for origin update.",
"properties": {
"tags": {
"description": "Origin tags.",
"type": "object",
"additionalProperties": {
"type": "string"
}
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/OriginUpdatePropertiesParameters"
Expand Down
4 changes: 0 additions & 4 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2019-12-31/examples/Origins_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"origin": {
"location": "WestUs",
"properties": {
"hostName": "www.someDomain.net",
"httpPort": 80,
Expand All @@ -25,7 +24,6 @@
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"location": "WestUs",
"properties": {
"provisioningState": "Succeeded",
"resourceState": "Active",
Expand All @@ -44,7 +42,6 @@
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"location": "WestUs",
"properties": {
"provisioningState": "Succeeded",
"resourceState": "Active",
Expand All @@ -63,7 +60,6 @@
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"location": "WestUs",
"properties": {
"provisioningState": "Succeeded",
"resourceState": "Active",
Expand Down
4 changes: 0 additions & 4 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2019-12-31/examples/Origins_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
4 changes: 0 additions & 4 deletions ...cdn/resource-manager/Microsoft.Cdn/stable/2019-12-31/examples/Origins_ListByEndpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
"value": [
{
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
11 changes: 0 additions & 11 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2019-12-31/examples/Origins_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"originUpdateProperties": {
"tags": {
"key1": "value1"
},
"properties": {
"httpPort": 42,
"httpsPort": 43,
Expand All @@ -24,10 +21,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -47,10 +40,6 @@
"body": {
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
"provisioningState": "Succeeded",
Expand Down
9 changes: 1 addition & 8 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/cdn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4428,7 +4428,7 @@
"type": "object",
"allOf": [
{
"$ref": "#/definitions/TrackedResource"
"$ref": "#/definitions/ProxyResource"
}
],
"properties": {
Expand Down Expand Up @@ -4474,13 +4474,6 @@
"type": "object",
"description": "Origin properties needed for origin update.",
"properties": {
"tags": {
"description": "Origin tags.",
"type": "object",
"additionalProperties": {
"type": "string"
}
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/OriginUpdatePropertiesParameters"
Expand Down
16 changes: 0 additions & 16 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/examples/Origins_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"origin": {
"location": "WestUs",
"tags": {
"key1": "value1"
},
"properties": {
"hostName": "www.someDomain.net",
"httpPort": 80,
Expand All @@ -26,10 +22,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -48,10 +40,6 @@
"201": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -70,10 +58,6 @@
"202": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
4 changes: 0 additions & 4 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/examples/Origins_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
4 changes: 0 additions & 4 deletions ...cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/examples/Origins_ListByEndpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
"value": [
{
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
11 changes: 0 additions & 11 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2020-03-31/examples/Origins_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"originUpdateProperties": {
"tags": {
"key1": "value1"
},
"properties": {
"httpPort": 42,
"httpsPort": 43,
Expand All @@ -24,10 +21,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -47,10 +40,6 @@
"body": {
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
"provisioningState": "Succeeded",
Expand Down
9 changes: 1 addition & 8 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2020-04-15/cdn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4452,7 +4452,7 @@
"type": "object",
"allOf": [
{
"$ref": "#/definitions/TrackedResource"
"$ref": "#/definitions/ProxyResource"
}
],
"properties": {
Expand Down Expand Up @@ -4514,13 +4514,6 @@
"type": "object",
"description": "Origin properties needed for origin update.",
"properties": {
"tags": {
"description": "Origin tags.",
"type": "object",
"additionalProperties": {
"type": "string"
}
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/OriginUpdatePropertiesParameters"
Expand Down
16 changes: 0 additions & 16 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2020-04-15/examples/Origins_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"origin": {
"location": "WestUs",
"tags": {
"key1": "value1"
},
"properties": {
"hostName": "www.someDomain.net",
"httpPort": 80,
Expand All @@ -29,10 +25,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -55,10 +47,6 @@
"201": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -81,10 +69,6 @@
"202": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
4 changes: 0 additions & 4 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2020-04-15/examples/Origins_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
4 changes: 0 additions & 4 deletions ...cdn/resource-manager/Microsoft.Cdn/stable/2020-04-15/examples/Origins_ListByEndpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
"value": [
{
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand Down
11 changes: 0 additions & 11 deletions ...ication/cdn/resource-manager/Microsoft.Cdn/stable/2020-04-15/examples/Origins_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
"endpointName": "endpoint1",
"originName": "www-someDomain-net",
"originUpdateProperties": {
"tags": {
"key1": "value1"
},
"properties": {
"httpPort": 42,
"httpsPort": 43,
Expand All @@ -25,10 +22,6 @@
"200": {
"body": {
"name": "www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
Expand All @@ -51,10 +44,6 @@
"body": {
"name": "www-someDomain-net",
"id": "/subscriptions/subid/resourcegroups/RG/providers/Microsoft.Cdn/profiles/profile1/endpoints/endpoint1/origins/www-someDomain-net",
"location": "WestUs",
"tags": {
"key1": "value1"
},
"type": "Microsoft.Cdn/profiles/endpoints/origins",
"properties": {
"provisioningState": "Succeeded",
Expand Down