[Hub Generated] Review request for Microsoft.Devices to add version stable/2020-03-01 #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01 to version 2020-03-01
…3-01' of https://github.com/rajeevmv/azure-rest-api-specs into dev-deviceprovisioningservices-Microsoft.Devices-2020-03-01
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
This was referenced Jul 13, 2020
|
Can one of the admins verify this patch? |
raych1
reviewed
Jul 14, 2020
| "$ref": "#/definitions/PrivateEndpointConnection" | ||
| } | ||
| }, | ||
| "PrivateEndpointConnection": { |
There was a problem hiding this comment.
There're common models defined for PrivateLinks. Suggest to re-use them.
There was a problem hiding this comment.
Is this required? or optional? The API has been integrated with Networking and UX and I would like to avoid changing them if possible.
There was a problem hiding this comment.
It appears that only storage and storagesync team are referring to this common model.
There was a problem hiding this comment.
This is required for all the new references. Otherwise it's very hard to keep the consistency. Please use the common model as suggested above.
There was a problem hiding this comment.
The feature has been shipped and is GA. We cannot make this change without breaking this API.
raych1
reviewed
Jul 14, 2020
| } | ||
| } | ||
| }, | ||
| "ErrorDetails": { |
There was a problem hiding this comment.
Can you reference the ErrorResponse defined in common type?
There was a problem hiding this comment.
The definition of ErrorResponse and ErrorDetails are different. I cannot change this without breaking the current API.
There was a problem hiding this comment.
Please fix the lintDiff check failures which is related to this.
There was a problem hiding this comment.
Here too, I cannot make this change without breaking the API of this feature which is GA
|
Thanks for using the copy the API in first commit and separating the changes. It helps immensely while reviewing. |
|
@akning-ms , can you help force merge this PR since the change is to align with service in production? Thanks. |
raych1
approved these changes
Jul 28, 2020
raych1
reviewed
Jul 28, 2020
|
|
||
| ``` yaml | ||
| directive: | ||
| - suppress: PageableOperation |
There was a problem hiding this comment.
All these three rules are warnings and doesn't need to be suppressed. It would not fail the lintDiff check. Can you remove this suppression section?
raych1
requested changes
Jul 28, 2020
|
@rajeevmv , can you remove the suppression part? |
|
Pull request contains merge conflicts. |
|
Pull request contains merge conflicts. |
Merge from main fork
|
Removed suppressions |
|
No commit pushedDate could be found for PR 10114 in repo Azure/azure-rest-api-specs |
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 4, 2020
|
Hi @akning-ms , could you help force merge this PR since the change is to align with service in production? Thanks. |
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.