Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones is missing in VirtualMachineScaleSetVM #3358

Closed
joshgav opened this issue Jul 5, 2018 · 3 comments
Closed

Zones is missing in VirtualMachineScaleSetVM #3358

joshgav opened this issue Jul 5, 2018 · 3 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute Service Attention Workflow: This issue is responsible by Azure service team. Service-team

Comments

@joshgav
Copy link

joshgav commented Jul 5, 2018

Copied from Azure/azure-sdk-for-go#2183 from @feiskyer

Zones is missing in VirtualMachineScaleSetVM. We need this to support availability zones in Kubernetes. Kubernetes is using 2017-12-01 compute api, but zones is also missing in latest 2018-04-01 version.

Zones has already been in VirtualMachineScaleSet, so we need add this also to VirtualMachineScaleSetVM.

https://github.com/Azure/azure-sdk-for-go/blob/fbe7db0e3f9793ba3e5704efbab84f51436c136e/services/compute/mgmt/2018-04-01/compute/models.go#L7548-L7570

Could some one help to add this?

cc @brendandburns @khenidak
cc @joshgav @jhendrixMSFT

@marstr
Copy link
Member

marstr commented Jul 5, 2018

Triaged, removing my assignment.

@marstr marstr removed their assignment Jul 5, 2018
@joshgav
Copy link
Author

joshgav commented Jul 9, 2018

cc @hyonholee

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@mjconnection mjconnection added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jun 17, 2019
@Drewm3
Copy link
Member

Drewm3 commented Sep 19, 2019

Cleaning up old issues from 2016 - 2018. Please reopen this issue if it is still a concern.

@Drewm3 Drewm3 closed this as completed Sep 19, 2019
sjiherzig added a commit that referenced this issue Dec 28, 2021
* Add SDK Generation Options for new API Version (#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
akning-ms pushed a commit that referenced this issue Feb 1, 2022
…italTwins-2021-06-30-preview-merge-with-main' (#17186)

* Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (#3404)

* Add SDK Generation Options for new API Version (#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>

* Align with repo (#5658)

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this issue Feb 1, 2022
…italTwins-2021-06-30-preview-merge-with-main' (Azure#17186)

* Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (Azure#3404)

* Add SDK Generation Options for new API Version (Azure#3179)

* Add SDK generation for 2021-06-30-preview

* The following fixes were done:
 * Fixed schema location: preview instead of stable
 * Updated go SDK generation to point to preview namespace

* Remove Ruby support

* add SystemData and update instance and endpoints definitions

* added systemdata to all examples

* fix typo

* fix prettier issues

* added experimental operations fix

* fixed some errors

* addressed lint and model errors

* fixed type issues with endpoints examples

* Fixed autorest error

* removed unnecessary _allOf_s

* Add Time Series Database Connection Resource and CRUD API Endpoints (Azure#3180)

* Added basic time series integration resource CRUD and resource description

* Add list call for TSDB integration resources

* Modify naming for adx endpoint

* Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations)

* Update operation names

* Resolve review comments

* Add examples for time series database connection CRUD

* Add example for missing status code 200 to DELETE

* Run prettier and fix formatting issues

* Align tags, solve issue in Python SDK generation

* Align python readme

* Fix linter error

* Fix linter error 2

* Fix linter error

* Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (Azure#3358)

* Address major lintdiff warnings

* Fix more linter warnings

* Address remaining lintdiff warnings and errors

* Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location

* Address lintdiff error

* Add systemData property to private endpoint connection resource

* Address breaking change warnings

* Fix inheritance

* Update suppressions to point to new locations in document

* Updated TSDB connection parameter set

* Fix issue in property set

* Revert readOnly=true from private endpoint connections property

* Revert change to TopicEndpoint

* Back to camelcase...

* Revert change in old API version

* Revert TopicEndpoint back to camelCase

* Revert allOf addition

* Change capitalization of TopicEndpoint back to original from previous version

* Add approved suppression

* Fix $.definitions path in suppression rules

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>

* Align with repo (Azure#5658)

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Co-authored-by: Nate Lehman <njlehman1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute Service Attention Workflow: This issue is responsible by Azure service team. Service-team
Projects
None yet
Development

No branches or pull requests

5 participants