Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cognitive Services - Knowledge] API Review Entity Matching #20705

Closed
azure-sdk opened this issue Sep 14, 2022 · 4 comments
Closed

[Cognitive Services - Knowledge] API Review Entity Matching #20705

azure-sdk opened this issue Sep 14, 2022 · 4 comments
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes. Cadl Authored with Cadl Cognitive - Knowledge

Comments

@azure-sdk
Copy link
Collaborator

Service Name: -
Review Created By: Leon Romaniuk
PR: #12345
Description: mini-batch Entity Matching API review
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Detailed meeting information and documents provided can be accessed here
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 14, 2022
@azure-sdk azure-sdk mentioned this issue Sep 14, 2022
Merged
25 tasks
@azure-sdk
Copy link
Collaborator Author

azure-sdk commented Sep 20, 2022 •
edited by maririos
Loading

Meeting updated by Mariana Rios Flores

Service Name: Cognitive Services
Review Created By: Mariana Rios Flores
Review Date: 9/28/2022 9:00 AM PT
PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/8838
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: mini-batch Entity Matching API review
Update to the Swagger PR link to https://github.com/Azure/azure-rest-api-specs-pr/pull/8838

Detailed meeting information and documents provided can be accessed here

@maririos maririos changed the title [ - ] API Review [Cognitive Services] API Review Sep 20, 2022
@markweitzel markweitzel changed the title [Cognitive Services] API Review [Cognitive Services - Knowledge] API Review Sep 27, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 27, 2022
@markweitzel markweitzel added API Review Scoping This is an issue that will track work on a specific set of API changes. Cadl Authored with Cadl labels Sep 27, 2022
@markweitzel markweitzel moved this to Triage in API Stewardship Sep 27, 2022
@markweitzel markweitzel moved this from Triage to In Progress in API Stewardship Sep 27, 2022
@markweitzel
Copy link
Member

markweitzel commented Sep 27, 2022 •
edited
Loading

API Stewardship Board Review: 27-Sep-22

  • Better description for id, e.g. matchId
  • The limits on the input for Entity BulkMatchOneResult should be captured & documented.
  • Consider renaming: resultStatus to status b/c then you would get result.status
  • Don’t have both error and result in the same response. It makes it very unclear to the consumer to understand. If there is diagnostics info regarding the result, then we should find another way to express it.

Recording & transcript

@markweitzel markweitzel changed the title [Cognitive Services - Knowledge] API Review [Cognitive Services - Knowledge] API Review Entity Matching Sep 27, 2022
@azure-sdk
Copy link
Collaborator Author

Cancelled by: Admin

Repository owner moved this from In Progress to Done in API Stewardship Sep 27, 2022
@markweitzel
Copy link
Member

When working with Cadl, we are now using:
https://github.com/Azure/azure-rest-api-specs-pr/issues/8594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes. Cadl Authored with Cadl Cognitive - Knowledge
Projects
API Stewardship
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markweitzel @azure-sdk