From 9d0897942951a808a0c7b3372c072de05b4e6cf0 Mon Sep 17 00:00:00 2001
From: susolank <73919400+susolank@users.noreply.github.com>
Date: Wed, 9 Jun 2021 15:21:29 -0700
Subject: [PATCH] [Hub Generated] Review request for Microsoft.KeyVault to add
 version preview/2021-04-01-preview (#14137)

* Support release key permission for vault access policies

* Remove 400 and 409 error codes from response object

* Fix model validation issues

* Remove extra 400 from deleted vault response
---
 .../examples/createVault.json                 | 18 ------
 .../examples/createVaultWithNetworkAcls.json  | 18 ------
 .../examples/deleteVault.json                 |  9 ---
 .../examples/purgeDeletedVault.json           |  9 ---
 .../examples/updateAccessPoliciesAdd.json     | 18 ------
 .../examples/updateVault.json                 | 18 ------
 .../preview/2021-04-01-preview/keyvault.json  | 59 +------------------
 7 files changed, 2 insertions(+), 147 deletions(-)

diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json
index 11ff6d983fef..100de9b5c198 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVault.json
@@ -265,24 +265,6 @@
           "provisioningState": "Succeeded"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json
index 2694b2d4a3db..c247e3597eb4 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/createVaultWithNetworkAcls.json
@@ -127,24 +127,6 @@
           "vaultUri": "https://sample-vault.vault.azure.net"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json
index c33aa9dbd5de..73f9b5320d62 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/deleteVault.json
@@ -11,15 +11,6 @@
     },
     "204": {
       "headers": {}
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json
index 1b3308e1ae9a..7141f4f20424 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json
@@ -12,15 +12,6 @@
     "202": {
       "headers": {}
     },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
     "404": {
       "headers": {},
       "body": {
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json
index eb488048b3f3..97c20be93866 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json
@@ -78,15 +78,6 @@
         }
       }
     },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
     "404": {
       "headers": {},
       "body": {
@@ -95,15 +86,6 @@
           "message": ""
         }
       }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json
index cc307b3f0ca4..b52c06bb7df8 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateVault.json
@@ -263,24 +263,6 @@
           "provisioningState": "Succeeded"
         }
       }
-    },
-    "400": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
-    },
-    "409": {
-      "headers": {},
-      "body": {
-        "error": {
-          "code": "",
-          "message": ""
-        }
-      }
     }
   }
 }
diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json
index b262450c4d41..f19b485e728b 100644
--- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json
+++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json
@@ -63,20 +63,6 @@
               "$ref": "#/definitions/Vault"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -150,20 +136,6 @@
               "$ref": "#/definitions/Vault"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -218,13 +190,6 @@
           "204": {
             "description": "No Content."
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -367,13 +332,6 @@
               "$ref": "#/definitions/VaultAccessPolicyParameters"
             }
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "404": {
             "description": "The specified resource does not exist.",
             "schema": {
@@ -381,13 +339,6 @@
             },
             "x-ms-error-response": true
           },
-          "409": {
-            "description": "A conflict occurred to prevent the operation from completing.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "default": {
             "description": "Error response describing why the operation failed.",
             "schema": {
@@ -657,13 +608,6 @@
           "202": {
             "description": "Vault is being purged."
           },
-          "400": {
-            "description": "Bad request.",
-            "schema": {
-              "$ref": "common.json#/definitions/CloudError"
-            },
-            "x-ms-error-response": true
-          },
           "404": {
             "description": "The specified resource does not exist.",
             "schema": {
@@ -1171,7 +1115,8 @@
               "backup",
               "restore",
               "recover",
-              "purge"
+              "purge",
+              "release"
             ],
             "x-ms-enum": {
               "name": "KeyPermissions",