Skip to content

Commit

Permalink
Revert "Rename Firewall Policy child resource RuleGroup to RuleCollec…
Browse files Browse the repository at this point in the history
…tionGroup (#9045)"

This reverts commit b49caab.
  • Loading branch information
saisujithreddym committed Apr 29, 2020
1 parent b49caab commit 4bc590e
Show file tree
Hide file tree
Showing 12 changed files with 229 additions and 229 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
"properties": {
"provisioningState": "Succeeded",
"threatIntelMode": "Alert",
"ruleCollectionGroups": [
"ruleGroups": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1"
}
],
"firewalls": []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"properties": {
"provisioningState": "Succeeded",
"threatIntelMode": "Alert",
"ruleCollectionGroups": [
"ruleGroups": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1"
}
],
"firewalls": []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
"properties": {
"provisioningState": "Succeeded",
"threatIntelMode": "Alert",
"ruleCollectionGroups": [
"ruleGroups": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1"
}
],
"firewalls": []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
"properties": {
"provisioningState": "Succeeded",
"threatIntelMode": "Alert",
"ruleCollectionGroups": [
"ruleGroups": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/rulegroup1"
},
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup2"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/rulegroup2"
}
],
"firewalls": []
Expand All @@ -53,12 +53,12 @@
"properties": {
"provisioningState": "Succeeded",
"threatIntelMode": "Alert",
"ruleCollectionGroups": [
"ruleGroups": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1"
},
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup2"
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/rulegroup2"
}
],
"firewalls": []
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"ruleCollectionGroupName": "ruleCollectionGroup1",
"ruleGroupName": "ruleGroup1",
"firewallPolicyName": "firewallPolicy",
"resourceGroupName": "rg1",
"api-version": "2020-04-01",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"ruleCollectionGroupName": "ruleCollectionGroup1",
"ruleGroupName": "ruleGroup1",
"firewallPolicyName": "firewallPolicy",
"resourceGroupName": "rg1",
"api-version": "2020-04-01",
Expand All @@ -9,24 +9,24 @@
"responses": {
"200": {
"body": {
"name": "ruleCollectionGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1",
"name": "ruleGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1",
"etag": "W/\"72090554-7e3b-43f2-80ad-99a9020dcb11\"",
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"priority": 200,
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-rule1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"sourceAddresses": [
"10.1.25.0/24"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,25 @@
"body": {
"value": [
{
"name": "ruleCollectionGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1",
"name": "ruleGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1",
"etag": "W/\"72090554-7e3b-43f2-80ad-99a9020dcb11\"",
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"name": "Example-Filter-Rule-Collection",
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule",
"ruleType": "FirewallPolicyFilterRule",
"priority": 120,
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"name": "network-rule-1",
"ruleType": "NetworkRule",
"description": "Network rule",
"name": "network-condition-1",
"ruleConditionType": "NetworkRuleCondition",
"description": "Network rule condition",
"destinationAddresses": [
"*"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@
"subscriptionId": "subid",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"ruleCollectionGroupName": "ruleCollectionGroup1",
"ruleGroupName": "ruleGroup1",
"parameters": {
"properties": {
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-rule1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"sourceAddresses": [
"10.1.25.0/24"
],
Expand All @@ -41,23 +41,23 @@
"responses": {
"200": {
"body": {
"name": "ruleCollectionGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1",
"name": "ruleGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-rule1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"sourceAddresses": [
"10.1.25.0/24"
],
Expand Down Expand Up @@ -85,17 +85,17 @@
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-rule1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"sourceAddresses": [
"10.1.25.0/24"
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"parameters": {
"ruleCollectionGroupName": "ruleGroup1",
"ruleGroupName": "ruleGroup1",
"firewallPolicyName": "firewallPolicy",
"resourceGroupName": "rg1",
"api-version": "2020-04-01",
Expand All @@ -15,18 +15,18 @@
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"priority": 200,
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-rule1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"ipProtocols": [
"TCP"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,25 @@
"body": {
"value": [
{
"name": "ruleCollectionGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1",
"name": "ruleGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1",
"etag": "W/\"72090554-7e3b-43f2-80ad-99a9020dcb11\"",
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"name": "Example-Filter-Rule-Collection",
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule",
"ruleType": "FirewallPolicyFilterRule",
"priority": 120,
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"name": "network-rule-1",
"ruleType": "NetworkRule",
"description": "Network rule",
"name": "network-condition-1",
"ruleConditionType": "NetworkRuleCondition",
"description": "Network rule condition",
"sourceIpGroups": [
"/subscriptions/subid/providers/Microsoft.Network/resourceGroup/rg1/ipGroups/ipGroups1"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@
"subscriptionId": "subid",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"ruleCollectionGroupName": "ruleCollectionGroup1",
"ruleGroupName": "ruleGroup1",
"parameters": {
"properties": {
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"ipProtocols": [
"TCP"
],
Expand All @@ -41,23 +41,23 @@
"responses": {
"200": {
"body": {
"name": "ruleCollectionGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleCollectionGroups/ruleCollectionGroup1",
"name": "ruleGroup1",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/ruleGroups/ruleGroup1",
"etag": "w/\\00000000-0000-0000-0000-000000000000\\",
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"ipProtocols": [
"TCP"
],
Expand Down Expand Up @@ -85,17 +85,17 @@
"properties": {
"provisioningState": "Succeeded",
"priority": 110,
"ruleCollections": [
"rules": [
{
"ruleCollectionType": "FirewallPolicyFilterRuleCollection",
"name": "Example-Filter-Rule-Collection",
"ruleType": "FirewallPolicyFilterRule",
"name": "Example-Filter-Rule",
"action": {
"type": "Deny"
},
"rules": [
"ruleConditions": [
{
"ruleType": "NetworkRule",
"name": "network-1",
"ruleConditionType": "NetworkRuleCondition",
"name": "network-condition1",
"ipProtocols": [
"TCP"
],
Expand Down
Loading

0 comments on commit 4bc590e

Please sign in to comment.