Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.DesktopVirtualization to…
Browse files Browse the repository at this point in the history
… add version preview/2022-10-14-preview (#21700)

* Adds base for updating Microsoft.DesktopVirtualization from version stable/2022-09-09 to version 2022-10-14-preview

* Updates readme

* Updates API version in new specs and examples

* Added removed changes from 2022-04-01-preview to 2022-10-14-preview

* Removed MigrationRequest from version

* Copied examples over from previous preview

* Added missing changes for private link to swagger

* Added enabled/disabled status to check descriptions.

* Added regex pattern to parameter in types.json

* reverted mistaken common type edit and added pattern to parameters

* Revert "Added enabled/disabled status to check descriptions."

This reverts commit ad177a4.

* Removed pattern requirement; will get exception on linter errors

* Revert "Revert "Added enabled/disabled status to check descriptions.""

This reverts commit 40ef1db.

* Replaced v1 and v2 common types with v3 and added 201 responses as directed from PR review.

* Only added v3 to new resources to avoid breaking changes

* Fixed incorrect find replace from param to def

* changed system data from v3 to v2 to avoid breaking changes

* Updated resource version from v3 to v1 to avoid breaking changes

* Removed added 201 responses

* Changed PrivateLinkResourceListResult to use internal definition and added pagination to PrivateLink collection calls

* Update to use same version of PrivateEndpointConnection type

* Update PrivateLink version from v3 to v2 to use the same Resource def

* Reverted PrivateLinkConnection v3 to v2 due to sdk problems.

* Added missed pagable to privatelink ListByHostpool
  • Loading branch information
alec-baird authored Dec 16, 2022
1 parent 038922f commit 0e9de49
Show file tree
Hide file tree
Showing 69 changed files with 11,122 additions and 2 deletions.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview",
"applicationGroup": {
"location": "centralus",
"tags": {
"tag1": "value1",
"tag2": "value2"
},
"properties": {
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"applicationGroupType": "RemoteApp"
}
}
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
},
"201": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview"
},
"responses": {
"200": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview"
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"api-version": "2022-10-14-preview",
"$filter": "applicationGroupType eq 'RailApplication'",
"pageSize": 10,
"isDescending": true,
"initialSkip": 0
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
{
"name": "applicationGroup2",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup2",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"api-version": "2022-10-14-preview",
"$filter": "applicationGroupType eq 'RailApplication'",
"pageSize": 10,
"isDescending": true,
"initialSkip": 0
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
},
{
"name": "applicationGroup2",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup2",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"subscriptionId": "daefabc0-95b4-48b3-b645-8a753a63c4fa",
"resourceGroupName": "resourceGroup1",
"applicationGroupName": "applicationGroup1",
"api-version": "2022-10-14-preview",
"applicationGroup": {
"tags": {
"tag1": "value1",
"tag2": "value2"
},
"properties": {
"description": "des1",
"friendlyName": "friendly"
}
}
},
"responses": {
"200": {
"body": {
"name": "applicationGroup1",
"id": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/applicationGroups/applicationGroup1",
"type": "Microsoft.DesktopVirtualization/applicationGroups",
"location": "centralus",
"tags": {
"key1": "value1",
"key2": "value2"
},
"systemData": {
"createdBy": "user1",
"createdByType": "User",
"createdAt": "2020-01-01T17:18:19.1234567Z",
"lastModifiedBy": "user2",
"lastModifiedByType": "User",
"lastModifiedAt": "2020-01-02T17:18:19.1234567Z"
},
"properties": {
"objectId": "7877fb31-4bde-49fd-9df3-c046e0ec5325",
"description": "des1",
"friendlyName": "friendly",
"hostPoolArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/hostPools/hostPool1",
"workspaceArmPath": "/subscriptions/daefabc0-95b4-48b3-b645-8a753a63c4fa/resourceGroups/resourceGroup1/providers/Microsoft.DesktopVirtualization/workspaces/workspace1",
"applicationGroupType": "RemoteApp",
"cloudPcResource": false
}
}
}
}
}
Loading

0 comments on commit 0e9de49

Please sign in to comment.