Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOT FOR IGNITE] [ADLA - ADLS] - Object refactoring #4594

Closed
wants to merge 3 commits into from
Closed

[NOT FOR IGNITE] [ADLA - ADLS] - Object refactoring #4594

wants to merge 3 commits into from

Conversation

ro-joowan
Copy link
Contributor

@ro-joowan ro-joowan commented Sep 14, 2017 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@ro-joowan
[ADLA - ADLS] - Object refactoring
977d4a8 
* Based on this Swagger PR: Azure/azure-rest-api-specs#1452

* Based on this .NET PR:
Azure/azure-sdk-for-net#3512

* Besides code refactoring for type changes, the only real change is
updating adapting to how Job submission/build works in
src\ResourceManager\DataLakeAnalytics\Commands.DataLakeAnalytics\Commands\SubmitAzureRmDataLakeAnalyticsJob.cs

* For the deleted PS<some properties object>.cs files, it is because via
Swagger these properties have been flattened.  E.g. in
src\ResourceManager\DataLakeAnalytics\Commands.DataLakeAnalytics\Models\PSDataLakeStoreAccountInfo.cs:

[Obsolete("In a future release this object will have all 'Properties'
properties flattened and the 'Properties' property will be removed.
Until then, nested properies will be duplicated.")]
* Updated the tests ever so slightly to make them more reliable.  I also
ran them live and updated the SessionRecords folder for both ADLA and
ADLS
@msftclas
Copy link

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@markcowl
Copy link
Member

@ro-joowan You need to make these changes in the privarte repository if they are meant for Ignite. There are instructions on moving PRs here: https://github.com/Azure/azure-powershell/wiki/Public-to-Private-Migration . Please let us know if you need help with this.

@markcowl markcowl closed this Sep 14, 2017
@ro-joowan
[CODE] - Updating a file in order to build a local msi sucessfully
83167d8 
* This change is already done in the private repo -- making this change
here now so that I can build a local msi succesfully
@cormacpayne
Copy link
Member

@markcowl this PR isn't meant for the Ignite release.

@cormacpayne cormacpayne reopened this Sep 14, 2017
@msftclas
Copy link

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@cormacpayne cormacpayne changed the title [ADLA - ADLS] - Object refactoring [NOT FOR IGNITE] [ADLA - ADLS] - Object refactoring Sep 14, 2017
@markcowl
Copy link
Member

Please open this PR after Ignite.

@markcowl markcowl closed this Sep 15, 2017
@ro-joowan
Copy link
Contributor Author

Sounds good -- I'll track it and ping after Ignite. Thank you

@ro-joowan ro-joowan deleted the object-refactor branch October 23, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ro-joowan @msftclas @markcowl @cormacpayne @azuresdkci @shahabhijeet