Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add params for New-AzGalleryApplicationVersion #18729

Merged
merged 7 commits into from
Jul 4, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Jun 26, 2022

Description

adding two new parameters for New-AzGalleryApplicationVersion

[-PackageFileName <string>] and [-ConfigFileName <string>]

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@grizzlytheodore grizzlytheodore marked this pull request as ready for review June 28, 2022 20:43
@grizzlytheodore
Copy link
Member Author

grizzlytheodore commented Jun 28, 2022

@VeryEarly
this feature needs to go in the 7/5. but the code merge date was 6/27. We missed it. Is there anyway this can go in there?
It's a simple update adding two new string parameters

@grizzlytheodore
Copy link
Member Author

how do i update the changelog when there isn't one in the generation branch?

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

test cases need to be re-recorded after API version upgrade

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@grizzlytheodore grizzlytheodore changed the title update readme add params for New-AzGalleryApplicationVersion Jun 29, 2022
@grizzlytheodore
Copy link
Member Author

grizzlytheodore commented Jun 29, 2022

all the tests? @VeryEarly

@grizzlytheodore
Copy link
Member Author

@VeryEarly
when I try to run the tests I get this error:
PS C:\Repositories\ps\src\Compute\Compute.Autorest> .\test-module.ps1 -record get-azgalleryapplication
Creating isolated process...

Creating ResourceGroup RGComputeTestnfr5c0pt
Name Location ProvisioningState


testpwshellcompute eastus Succeeded
RGComputeTestnfr5c0pt eastus Succeeded
Pester v4.10.1
Executing all tests in 'C:\Repositories\ps\src\Compute\Compute.Autorest\test' matching test name get-azgalleryapplication

Executing script C:\Repositories\ps\src\Compute\Compute.Autorest\test\Get-AzGalleryApplication.Tests.ps1
Running 'record' mode...
Recording to C:\Repositories\ps\src\Compute\Compute.Autorest\test\Get-AzGalleryApplication.Recording.json

Describing Get-AzGalleryApplication
[-] Error occurred in Describe block 0ms
FileLoadException: Assembly with same name is already loaded
CmdletInvocationException: Assembly with same name is already loaded
CommandNotFoundException: The 'New-AzGallery' command was found in the module 'Az.Compute', but the module could not be loaded. For more information, run 'Import-Module Az.Compute'.

at , C:\Repositories\ps\src\Compute\Compute.Autorest\test\Get-AzGalleryApplication.Tests.ps1: line 19
at Invoke-Blocks, C:\Repositories\ps\src\Compute\Compute.Autorest\generated\modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135
at Invoke-TestGroupSetupBlocks, C:\Repositories\ps\src\Compute\Compute.Autorest\generated\modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121
at DescribeImpl, C:\Repositories\ps\src\Compute\Compute.Autorest\generated\modules\Pester\4.10.1\Functions\Describe.ps1: line 209

I've tried adding "Import-Module Az.Compute" in the "BeforeAll" block, and also the "It" block, also I've tried importing it in terminal before running the test, but they all fail the same. What do I do here?

@VeryEarly VeryEarly self-assigned this Jun 30, 2022
@VeryEarly VeryEarly merged commit 28dfa17 into generation Jul 4, 2022
@VeryEarly VeryEarly deleted the feature/cplat-vmgalleryapplication branch July 4, 2022 00:53
@VeryEarly VeryEarly mentioned this pull request Jul 5, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants