Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CosmosDB] Refactoring Code #11803

Merged
merged 9 commits into from
May 7, 2020
Merged

[CosmosDB] Refactoring Code #11803

merged 9 commits into from
May 7, 2020

Conversation

MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented May 6, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented May 6, 2020

Can one of the admins verify this patch?

@MehaKaushik MehaKaushik changed the title Users/mekaushi/byok2 [CosmosDB] Refactoring Code May 6, 2020
@isra-fel isra-fel self-assigned this May 6, 2020
@MehaKaushik MehaKaushik linked an issue May 6, 2020 that may be closed by this pull request
Get-AzCosmosDBSqlContainer errors with null ref when run on a container that does not have a unique key policy. It runs as expected when run on a container that does have a unique key policy. #11381
Closed
@MehaKaushik MehaKaushik added this to the S169 (2020-05-18) - Build milestone May 6, 2020
@wyunchi-ms wyunchi-ms merged commit 4066526 into Azure:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

Assignees

@isra-fel isra-fel

Labels
needs-review
Projects
None yet
Milestone
S169 (2020-05-18) - Build
4 participants
@MehaKaushik @adxsdkps @wyunchi-ms @isra-fel