Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Databricks autogen module #11448

Merged
merged 10,000 commits into from
Apr 9, 2020
Merged

Add Databricks autogen module #11448

merged 10,000 commits into from
Apr 9, 2020

Conversation

dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Mar 30, 2020 •
edited
Loading

Description

Fix #10879

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

dingmeng-xue and others added 30 commits March 5, 2020 13:20
@dingmeng-xue
Merge pull request Azure#11234 from wyunchi-ms/wyunchi/bugfix/network…
a0d5839 
…-changelog

Update changelog for Az.Network
@dingmeng-xue
Merge branch 'release-2020-03-10' into bowen/20200310
0c3120d
@bashahee
Merge pull request #1 from Azure/master
2dd8ffd 
Sync
@dingmeng-xue
Merge pull request Azure#11246 from bowen0106/bowen/20200310
e2682c0 
BugFix for PrivateLinkServiceConnectionState
@dingmeng-xue
merge from release branch
f152ced
@dingmeng-xue
for RC2 release
b0b3f79
update changelog
bdc9abc
@isra-fel
Merge pull request Azure#11243 from hyonholee/march
1e61d9b 
[Compute] Show the exact string value for VM PowerState in the table format.
@isra-fel
Merge branch 'master' into patch-1
2b69a50
@isra-fel
Merge pull request Azure#11241 from shawnxzq/sdk4.8
575d54a 
[DataFactory] Upgrade SDK to 4.8.0
@nagula-ritvika
updated changelog
998bf6d
@nagula-ritvika
updated changelog for upcoming release
422a33d
@eltociear
Fix typo
34c6aa0 
infomation→information
@anusapan
PR comments has been resolved
c7f7c3a
@anusapan
Merge branch 'master' of https://github.com/Azure/azure-powershell in…
9e10aa7 
…to iot-distributed-tracing
@anusapan
Updated help content
28eb371
@anthony-c-martin
Display ResourceManager correlationIds in error output
1e8d5b3
@aygoya
close ticket function.
358e1cf
@dingmeng-xue
For final RC
0b029e8
@dingmeng-xue
For final RC
ac71335
@dingmeng-xue
Merge pull request Azure#11256 from dingmeng-xue/release-2020-03-10
134f938 
Release 2020 03 10
@dingmeng-xue
Resolve conflicts
69ed678
@baselmicrosoft
Adding SensitivityRank parameter to DataClassification Set Cmdlets
b2604f9
@isra-fel
Merge pull request Azure#11260 from Azure/release-2020-03-10
8798f32 
Merge release-2020-03-10 to master
@aygoya
typo, unused imports. - enable severity, status tests. update propert…
2de4b04 
…ies count( since prod outage was removed). add tests for ticket status.
@aygoya
properties count to 5
941ec3a
@aygoya
count for prob class to 5
b18267d
@isra-fel
Merge pull request Azure#11249 from BillSproule/patch-1
2ed4c20 
Get-AzGalleryImageVersion fix example args
@isra-fel
Merge pull request Azure#10931 from theheatDK/patch-9
df5c057 
Update New-AzScheduledQueryRuleLogMetricTrigger.md
@jagilber
fix get-azresource -ResourceGroupName -Name -ResourceType to use corr…
9509ade 
…ect ApiVersion
@dingmeng-xue dingmeng-xue added this to the S168 (2020-04-21) milestone Mar 30, 2020
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue marked this pull request as ready for review March 30, 2020 10:30
dolauli
dolauli reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder tools and resources are not needed. And the others look good to me.

@dingmeng-xue dingmeng-xue mentioned this pull request Apr 6, 2020
Merged
8 tasks
dolauli
dolauli reviewed Apr 7, 2020
View reviewed changes
src/Databricks/Az.Databricks.csproj Outdated
</PropertyGroup>

<ItemGroup>
<PackageReference Include="PowerShellStandard.Library" Version="5.1.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean the comments.

dolauli
dolauli reviewed Apr 7, 2020
View reviewed changes
src/Databricks/Databricks.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Authentication", "..\Accounts\Authentication\Authentication.csproj", "{62843FE6-7575-4D88-B989-7DF7EEC0BC01}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Authentication.ResourceManager", "..\Accounts\Authentication.ResourceManager\Authentication.ResourceManager.csproj", "{442C609B-A431-4A71-B289-08F0B63C83E5}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Accounts, Authentication, Authenticators, Authentication.ResourceManager are required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it there following convention.

dolauli
dolauli reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And two minor comments.

isra-fel
isra-fel reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/Databricks/MSSharedLibKey.snk was this file chewcked in by accident?

src/Databricks/Az.Databricks.psd1 Outdated
RootModule = './Az.Databricks.psm1'

# Version number of this module.
ModuleVersion = '0.0.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version usually starts from 0.1.0
See https://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase

src/Databricks/ChangeLog.md Outdated
-->
## Upcoming Release

## Version 0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here too :)

src/Databricks/Properties/AssemblyInfo.cs Outdated
[assembly: ComVisible(false)]
[assembly: CLSCompliant(false)]
[assembly: Guid("4D3E68BD-35BC-4C97-8F40-A832CBA17AF7")]
[assembly: AssemblyVersion("0.0.1")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

@dingmeng-xue
Copy link
Member Author

src/Databricks/MSSharedLibKey.snk was this file chewcked in by accident?

Keep it there following current Autorest structure.

@dingmeng-xue dingmeng-xue merged commit b64991e into Azure:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel left review comments

@dolauli dolauli dolauli approved these changes

Assignees

@dolauli dolauli

Labels
needs-review
Projects
None yet
Milestone
S168 (2020-04-21)
Development

Successfully merging this pull request may close these issues.

Initial support for DataBricks service