-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Network Gateway Commandlets Update for BgpSettings #11424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ps metric definition
Add Minimal Tls Version Optional Parameter for SQLDB/MI
…ets. (Microsoft.IdentityModel.*)
LTR MI cmdlets and tests
AzAttestation Bug Fix: Add three missing required assemblies
Update samples to use proper argument -GalleryImageDefinitionName not -ImageDefinitionName
…gelog Update changelog for Az.Network
anton-evseev
previously approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please also generate help file for new cmdlet
Added help file. Thanks |
New vngbg pchanges
msJinLei
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are introducing a new PSIpConfigurationBgpPeeringAddress object which will be used in PSBgpSettings. Customer can provide bgpPeering addresses for the gateway using this property.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/Network/Network/ChangeLog.md
## Upcoming Release
header -- no new version header should be addedhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/514 (Microsoft internal only)