Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Network Gateway Commandlets Update for BgpSettings #11424

Merged
merged 10,000 commits into from
Apr 1, 2020
Merged

Virtual Network Gateway Commandlets Update for BgpSettings #11424

merged 10,000 commits into from
Apr 1, 2020

Conversation

Khushboo-Baheti
Copy link
Member

Description

We are introducing a new PSIpConfigurationBgpPeeringAddress object which will be used in PSBgpSettings. Customer can provide bgpPeering addresses for the gateway using this property.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/Network/Network/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

dingmeng-xue and others added 30 commits March 4, 2020 20:37
Add Minimal Tls Version Optional Parameter for SQLDB/MI
AzAttestation Bug Fix: Add three missing required assemblies
Update samples to use proper argument  -GalleryImageDefinitionName not -ImageDefinitionName
@Khushboo-Baheti Khushboo-Baheti removed their assignment Mar 27, 2020
anton-evseev
anton-evseev previously approved these changes Mar 27, 2020
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please also generate help file for new cmdlet

@Khushboo-Baheti
Copy link
Member Author

Khushboo-Baheti commented Mar 27, 2020

LGTM but please also generate help file for new cmdlet

Added help file. Thanks

Khushboo Baheti added 2 commits March 31, 2020 18:47
@msJinLei msJinLei merged commit 50aaa7a into Azure:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.