Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RecoveryServices.Backup] Added support for disk exclusion during Backup and Restore #11378

Merged
merged 13 commits into from
Mar 24, 2020
Merged

[RecoveryServices.Backup] Added support for disk exclusion during Backup and Restore #11378

merged 13 commits into from
Mar 24, 2020

Conversation

sambitratha
Copy link
Contributor

Description

Added support for disk exclusion during Backup and Restore

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@sambitratha sambitratha force-pushed the users/sarath/disk-ex branch from 9c7d2ec to 0dc9881 Compare March 20, 2020 13:53
@isra-fel isra-fel self-assigned this Mar 20, 2020
isra-fel
isra-fel requested changes Mar 23, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see my inline comment. Besides, it would be best if we can add new examples (update existing ones) for the new parameters.

...rvices/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesBackupProtection.cs Outdated
/// <summary>
/// List of Disk LUNs to include in backup
/// </summary>
[Parameter(Mandatory = false, ParameterSetName = AzureVMClassicComputeParameterSet)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add HelpMessage to these new parameters, and regenerate help docs please.

@isra-fel isra-fel assigned sambitratha and unassigned isra-fel Mar 23, 2020
isra-fel
isra-fel approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@isra-fel isra-fel assigned isra-fel and unassigned sambitratha Mar 23, 2020
@isra-fel isra-fel merged commit efa2a05 into Azure:master Mar 24, 2020
@isra-fel isra-fel mentioned this pull request Mar 24, 2020
Merged
8 tasks
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#11378 from MabOneSdk/users/sarath/disk-ex
2d55a0f 
[RecoveryServices.Backup] Added support for disk exclusion during Backup and Restore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambitratha @adxsdkps @isra-fel