Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RecoveryServices.Backup]Added support for restoring multiple files/folders in AzureFileShare #11373

Merged

Conversation

sambitratha
Copy link
Contributor

@sambitratha sambitratha commented Mar 19, 2020

Description

Added support for restoring multiple files/folders in AzureFileShare

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/508

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@isra-fel isra-fel self-assigned this Mar 19, 2020
@sambitratha sambitratha force-pushed the users/sarath/multiple-file-restore branch 2 times, most recently from 57a5133 to 06d089c Compare March 20, 2020 13:51
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see my inline comments. Besides, could you add an example to restore multiple items? Thanks

@isra-fel
Copy link
Member

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

isra-fel
isra-fel previously approved these changes Mar 23, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel
Copy link
Member

Hi @sambitratha , as #11378 was merged, it introduced some conflicts which blocks automatic merging. Could you resolve the conflicts? Thanks
Btw I don't have the permission to push to your fork.

@sambitratha sambitratha force-pushed the users/sarath/multiple-file-restore branch from 8f46948 to 35fdf5e Compare March 24, 2020 04:52
@sambitratha
Copy link
Contributor Author

Hi @isra-fel i have force-pushed the branch with conflicts resolved. Please approve

@isra-fel isra-fel changed the base branch from master to release-2020-03-31 March 24, 2020 05:07
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; changing the target branch to release branch

@isra-fel isra-fel merged commit feaa860 into Azure:release-2020-03-31 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants