Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IotHub] Manage distributed settings per-device #11226

Merged
merged 6 commits into from
Mar 9, 2020
Merged

[IotHub] Manage distributed settings per-device #11226

merged 6 commits into from
Mar 9, 2020

Conversation

anusapan
Copy link
Contributor

@anusapan anusapan commented Mar 3, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@anusapan
Copy link
Contributor Author

anusapan commented Mar 3, 2020

Cmdlet review design has been approved
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/501

@anusapan anusapan force-pushed the iot-distributed-tracing branch from e3cc84c to 712145c Compare March 3, 2020 00:41
@isra-fel isra-fel self-assigned this Mar 3, 2020
@anusapan
Copy link
Contributor Author

anusapan commented Mar 3, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@anusapan
Copy link
Contributor Author

anusapan commented Mar 4, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel
isra-fel requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anusapan please see my inline comments

@isra-fel isra-fel assigned anusapan and unassigned isra-fel Mar 5, 2020
@anusapan anusapan requested a review from isra-fel March 5, 2020 21:08
@anusapan
Copy link
Contributor Author

anusapan commented Mar 5, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel assigned isra-fel and unassigned anusapan Mar 6, 2020
isra-fel
isra-fel approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit d3ec79b into Azure:master Mar 9, 2020
@isra-fel isra-fel mentioned this pull request Mar 9, 2020
Merged
8 tasks
@anusapan anusapan deleted the iot-distributed-tracing branch March 9, 2020 17:13
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#11226 from anusapan/iot-distributed-tracing
cbbd122 
[IotHub] Manage distributed settings per-device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anusapan @isra-fel