Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation change for Set-AzDiagnosticSetting #9775

Closed
bwren opened this issue Aug 6, 2019 · 7 comments
Closed

Documentation change for Set-AzDiagnosticSetting #9775

bwren opened this issue Aug 6, 2019 · 7 comments

Comments

@bwren
Copy link

bwren commented Aug 6, 2019

Description

Documentation issue with Set-AzDiagnosticSetting. The description for WorkspaceId parameter is misleading.

Current:
The Id of the workspace

Should be changed to:
The Resource ID of the workspace.

@markcowl markcowl added Service Attention This issue is responsible by Azure service team. Monitor - Diagnostic Settings labels Aug 6, 2019
@ghost
Copy link

ghost commented Aug 6, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kshitizm

@markcowl
Copy link
Member

markcowl commented Aug 6, 2019

@gucalder can you take a look?

@bwren
Copy link
Author

bwren commented Aug 13, 2019

@gucalder @markcowl Just looking for an update on this.

@mortenlerudjordet
Copy link

Please make this change as -WorkspaceId is misleading

@asheniam asheniam removed the Service Attention This issue is responsible by Azure service team. label Jan 31, 2020
@dingmeng-xue
Copy link
Member

@bwren , please share how you are using -WorkspaceId.

@markcowl
Copy link
Member

@dingmeng-xue One of the patterns we normally follow is that when '*Id' is used as a parameter, it represents a GUID - in the case where this is also an external reference to a resource, the advice is to allow either resourceId or guid input. The code of the cmdlet should tell us the appropriate usage, and determine what change is needed to help.

@VeryEarly
Copy link
Collaborator

fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants