Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Support for soft-delete on/off/null as a one time operation #10555

Closed
8 tasks
dingmeng-xue opened this issue Nov 17, 2019 · 2 comments · Fixed by #11469
Closed
8 tasks

[KeyVault] Support for soft-delete on/off/null as a one time operation #10555

dingmeng-xue opened this issue Nov 17, 2019 · 2 comments · Fixed by #11469
Assignees
Labels
Azure PS Team feature-request This issue requires a new behavior in the product in order be resolved. KeyVault

Comments

@dingmeng-xue
Copy link
Member

dingmeng-xue commented Nov 17, 2019

Description of the new feature

Keyvault team are changing the default behavior that when creating a new keyvault, it's soft-delete is on.
We need to make sure:

  • The default behavior remains the same (soft delete is off) so as to keep it compatible
  • Provide a one-time operation to enable soft delete (this cannot be undone)

Proposed implementation details (optional)

Since the requirement is changing a property of the keyvault resource, idealy we should add an optional parameter [-EnableSoftDelete] to the Update-AzKeyVault cmdlet, but that cmdlet does not exist (only get- new- remove-), so we might need to add a update- cmdlet.

  • .Net SDK
    • Update api version
    • Write scenario tests
  • PowerShell
    • Utilize new SDK
    • Keep the current behavior of New-AzKeyVault
    • A new cmdlet: Update-AzKeyVault
    • Tests
@dingmeng-xue dingmeng-xue added KeyVault Azure PS Team feature-request This issue requires a new behavior in the product in order be resolved. labels Nov 17, 2019
@dingmeng-xue dingmeng-xue added this to the S162 (2019-12-17) milestone Nov 17, 2019
@isra-fel
Copy link
Member

Scenario tests

  • .NET SDK
    • Create a new keyvault without enableSoftDelete, the keyvault should enable soft-delete
    • Create a new keyvault with enableSoftDelete = false, the keyvault should not enable soft-delete
  • PowerShell cmdlet
    • New-AzKeyVault without -EnableSoftDelete, the keyvault should not enable soft-delete
    • New-AzKeyVault with -EnableSoftDelete, the keyvault should enable soft-delete
    • Update-AzKeyVault with -EnableSoftDelete, if it's not enabled, the keyvault should enable soft-delete
    • Update-AzKeyVault with -EnableSoftDelete, if it's already enabled, the keyvault should prompt a warning

@isra-fel
Copy link
Member

isra-fel commented Dec 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure PS Team feature-request This issue requires a new behavior in the product in order be resolved. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants