Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include transport static library to libprov_device_client.so #496

Closed
syedelec opened this issue May 21, 2018 · 2 comments
Closed

include transport static library to libprov_device_client.so #496

syedelec opened this issue May 21, 2018 · 2 comments
Assignees
Labels

Comments

@syedelec
Copy link

  • OS and version used:
    Ubuntu

  • SDK version used:
    master

Description of the issue:

When compiling a DPS application linking with -lprov_device_client, I still need to link against static library corresponding to the correct protocol I am using (e.g: AMQP_WS -lprov_amqp_ws_transport)

I thought that linking was done the same way as iothub_client library, all static library are included in the dynamic library. Instead we should use the use_amqp or use_http options in cmake to select the needed transport

The error is :
undefined reference to "Prov_Device_AMQP_WS_Protocol"

Code sample exhibiting the issue:

N/A

Console log of the issue:

undefined reference to 'Prov_Device_AMQP_WS_Protocol'
collect2: error: ld returned 1 exit status

@jebrando jebrando self-assigned this May 22, 2018
@jebrando
Copy link
Contributor

Currently for DPS we try to minimize dependencies that are automatically included and require the user to add the libraries. I don't believe that add the protocol library is not an unreasonable request, but I shall talk to the project managers to see if this should remain this way.

@jebrando
Copy link
Contributor

jebrando commented Jun 1, 2018

I has been decided that requiring the library is a step that must be done. Thank you for the issue.

@jebrando jebrando closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants