-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device provisioning errors using tpm #1446
device provisioning errors using tpm #1446
Comments
@mlilien thanks for the report: I was able to repro this using the description above and by blocking DNS (port 53) ( |
@mlilien I have a tentative fix in #1455. Could you please sync to https://github.com/Azure/azure-iot-sdk-c/tree/cipop/prov-fix1 (ensuring that submodules are up to date Please note that for Provisioning Client we do not support retry and so, in both cases (with or without a timeout), the failure is reported immediately to the application. In both cases the callback should be called with |
@CIPop Hi, If
the threadloop was slightly changed to the sample code above:
|
Thanks @mlilien for giving this a try! I was able to repro part of the condition you're describing. I have a potential fix in the same PR. Please give it another try (with and without timeout). One the items I couldn't repro are the error codes: Please check that your You'll need to sync to my branch (which should be on top of the current master - this bug doesn't meet the LTS bug bar so you'll need to switch), sync all submodules and check to see no diffs in them as well as update the sample with the |
Hi @CIPop, thank you, the fix works well. The error code problem was indeed a local one, I tested the older Is the LTS bug bar described somewhere? For us this is an important use case. Our devices are connected via LTE and wie saw this behaviour in our test and prod environment. |
@mlilien excellent to hear! I will proceed to merge the c-utility and the master changes.
The LTS bug bar and expectations are described here: https://github.com/Azure/azure-iot-sdk-c#long-term-support |
@CIPop, @mlilien, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey |
Got auto-closed by c-utility. Needs the check-in to master for this to be done. |
Development Machine, OS, Compiler (and Other Relevant Toolchain Info)
Dockerfile with build environment is part of Bugdescription
SDK Version (Please Give Commit SHA if Manually Compiling)
Protocol
Description
Bug 1: When the sample below (adapted for TPM) is configured without
PROV_OPTION_TIMEOUT
and the sample starts before there is a WAN connection available, the current LTS_02_2020_Ref01 version never callsregister_device_callback
.Bug 2: As a workaround I tried to set
PROV_OPTION_TIMEOUT
. In this case the callbackregister_device_callback
is called multiple times in ms. Seems the timer doesnt get reset. As an user of the SDK I only expect the callback to be called once.Adapted prov_dev_client_sample from sdk for TPM
Docker-Container with build environment
Log using
PROV_OPTION_TIMEOUT
The text was updated successfully, but these errors were encountered: