Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs from handle_version_update is not shown in --debug mdoe #19201

Open
jiasli opened this issue Aug 12, 2021 · 1 comment
Open

Logs from handle_version_update is not shown in --debug mdoe #19201

jiasli opened this issue Aug 12, 2021 · 1 comment
Assignees
Milestone

Comments

@jiasli
Copy link
Member

jiasli commented Aug 12, 2021

During the execution of handle_version_update, all logger invocations are not printed even if --debug is specified. This is because handle_version_update is called in AzCli.__init__, long before the logger is initialized.

This makes the troubleshooting of handle_version_update difficult.

Knack previously introduced init_debug_log and init_info_log to save __init__ logs (microsoft/knack#209), but an easier solution would be to call handle_version_update after the logger is initialized.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 12, 2021
@jiasli jiasli self-assigned this Aug 12, 2021
@jiasli jiasli added the Upgrade az upgrade label Aug 12, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 12, 2021
@jiasli jiasli added this to the Backlog milestone Aug 12, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 12, 2021

upgrade

@jiasli jiasli modified the milestones: Backlog, Aug 2021 (2021-09-07) Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants