Add expand:instanceView for GET VMScaleSetVM

[szimmer-dev]

Resource Provider
What is the Azure resource provider your feature is part of?
Microsoft.Compute

Description of Feature or Work Requested
Provide a brief description of the feature or work requested. A link to conceptual documentation may be helpful too.

GET for VMScaleSet VM has added an expand parameter to the swagger spec to display the instance view.

Minimum API Version Required
What is the minimum API version of your service required to implement your feature?

Swagger Link
Provide a link to the location of your feature(s) in the REST API specs repo. This should be on the master branch
of the REST API specs repo.

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json

"operationId": "VirtualMachineScaleSetVMs_Get",
"name": "$expand",
"enum": [
"instanceView"

line 4688

Target Date
If you have a target date for release of this feature/work, please provide it. While we can't guarantee these dates,
it will help us prioritize your request against other requests.
8/31/2019

[qwordy]

Next time, provide a pull request link so that we can see the swagger changes.
Thank you!

[qwordy]

And what's the effect to Azure CLI? We have show and get-instance-view.

[szimmer-dev]

I am unsure how the CLI works with respect to show and get-instance-view.

The new properties should be visible. Will updating the swagger import not just automatically display the new properties?

Here is my pull request link:
Azure/azure-rest-api-specs#6683

If you want us to include the pull request link in the future I would suggest that you ask for it in the issue creation template. Currently it asks for a link to the file in master with the changes.

[qwordy]

OK. Thank you. We will revise the issue template.

vmss show visit GET https://management.azure.com/subscriptions/{...}/resourceGroups/{...}/providers/Microsoft.Compute/virtualMachineScaleSets/{name}?api-version=2019-03-01.

vmss get-instance-view visit GET https://management.azure.com/subscriptions/{...}/resourceGroups/{...}/providers/Microsoft.Compute/virtualMachineScaleSets/{name}/instanceView?api-version=2019-03-01.

What's the difference between virtualMachineScaleSets/{name}?$expand=instanceView and virtualMachineScaleSets/{name}/instanceView?

[qwordy]

Copy comments from szimmer:

virtualMachineScaleSets/{name}?$expand=instanceView returns the vmScaleSet goal state with a property named instance view populated (instanceView is expensive runtime state)
virtualMachineScaleSets/{name}/instanceView just returns the expensive runtimestate without the vmScaleSet goal state infromation