-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serial-Console] Fix pair mapping region for eastus to westus #6231
Conversation
Hi @rhkodiak, |
Thank you for your contribution rhkodiak! We will review the pull request and get back to you soon. |
Serial-Console |
Can this be looked at? |
Please fix CI issues first. |
@rhkodiak there's other changes mixed in with the one for my issue. Can you resolve the issues so the PR goes through? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @rhkodiak You may need to record the failed tests again. |
@rhkodiak are you able to resolve the failing tests? |
@rhkodiak it seems like the last build also had some errors? https://github.com/Azure/azure-cli-extensions/pull/6231/checks?check_run_id=13531660777 |
@msftvito - when I run the "azdev test serial-console --live" command to record the new test results the command completes successfully for me. I look at the build log where the failure occurs but I don't see why it fails here and not when I locally run the live tests. Can you run the command and see if you get the same results? ![]() |
Hi @rhkodiak, according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of |
Hi @kairu-ms, I ran the instructions you provided and everything looks good now so ready for you to review. Thanks for the help! |
[Release] Update index.json for extension [ serial-console ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=59480&view=results |
Thank you everyone for getting this merged in! |
The changes in the pull request are to address a problem found in the azure cli serial-console extension where an error was being thrown for eastus connections because there wasn't a pair region mapping for westus. The code changes add the eastus to westus region mappings to fix this issue.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az serial-console connect -g MyResourceGroup -n MyVmName
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.