[Hardwaresecuritymodules] Bump up sdk and az dedicated-hsm: add parameters --mgmt-network-subnet and --mgmt-network-interfaces
#4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up SDK and 'az dedicated-hsm': add parameters
|
Hardwaresecuritymodules |
jsntcy
reviewed
May 25, 2022
| @@ -9,9 +9,12 @@ | |||
| from codecs import open | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| # TODO: Confirm this is the right version number you want and it matches your | |||
| # HISTORY.rst entry. | |||
| VERSION = '0.1.0' | |||
There was a problem hiding this comment.
Please change the version to 0.2.0
jsntcy
reviewed
May 25, 2022
jsntcy
reviewed
May 25, 2022
jsntcy
reviewed
May 25, 2022
| @@ -4,7 +4,7 @@ Release History | |||
| =============== | |||
| 0.2.0 | |||
| ++++++ | |||
| * 'az dedicated-hsm': add parameters '--mgmt-network-subnet' and '--mgmt-network-interfaces' and | |||
| * 'az dedicated-hsm': add parameters '--mgmt-network-subnet' and '--mgmt-network-interfaces' | |||
| * Bump up SDK to 2021_11_30 | |||
There was a problem hiding this comment.
Remove the note of this line as API version used in SDK is an implementation detail that should not be exposed to customers.
jsntcy
reviewed
May 25, 2022
| @@ -4,7 +4,7 @@ Release History | |||
| =============== | |||
| 0.2.0 | |||
| ++++++ | |||
| * 'az dedicated-hsm': add parameters '--mgmt-network-subnet' and '--mgmt-network-interfaces' and | |||
| * 'az dedicated-hsm': add parameters '--mgmt-network-subnet' and '--mgmt-network-interfaces' | |||
There was a problem hiding this comment.
Capitalize 'add` to Add' as it's our convention.
…u/azure-cli-extensions into hardwaresecuritymodules
kairu-ms
reviewed
May 26, 2022
| with open('README.md', 'r', encoding='utf-8') as f: | ||
| README = f.read() | ||
| with open('HISTORY.rst', 'r', encoding='utf-8') as f: | ||
| HISTORY = f.read() | ||
|
|
||
| setup( | ||
| name='hardware-security-modules', |
There was a problem hiding this comment.
Change this name will cause breaking change, could you use the previous name
kairu-ms
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.