Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'az webapp config ssl bind' for web apps in kubernetes environments #4129

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

StrawnSC
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@StrawnSC StrawnSC marked this pull request as ready for review November 18, 2021 21:29
@yonzhan yonzhan added this to the Nov 2021 (2021-12-07) milestone Nov 18, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2021

webapp

@StrawnSC StrawnSC requested a review from panchagnula November 18, 2021 22:51
@StrawnSC StrawnSC marked this pull request as draft November 18, 2021 23:31
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update setup.py to release the new extension version.
And may I ask you to add some scenario tests for those new commands?

@panchagnula
Copy link
Contributor

@StrawnSC is this PR ready for review & if so can we get this released on the extension soon. Thanks!

@StrawnSC
Copy link
Contributor Author

@panchagnula sorry for the hold up -- I was taking some time to test and make sure that certificate binding was working for lima web apps and lima web app slots. I'm marking the PR ready for review

@wangzelin007 thanks, I just updated the setup.py. About scenario tests, as we mentioned here, the process of setting up an AKS cluster to put kubernetes environments in is quite lengthy/time-consuming and doesn't lend itself well to automated testing. So far, we've been manually testing the commands. We're planning on finding a way to add scenario tests before integrating this into the core CLI

@StrawnSC StrawnSC marked this pull request as ready for review November 30, 2021 18:13
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panchagnula panchagnula merged commit 192c045 into Azure:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants