-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[baremetal] Adding the baremetal extension to the overall cli extension repo #2510
[baremetal] Adding the baremetal extension to the overall cli extension repo #2510
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
baremetal |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the name of the index entry
Hi, @pabowers @AprilZhaoWY! Nice to meet you. I believe it's the first time we meet in Azure CLI Extensions. I don't know whether you have contacted other ones on the team and they know the context or not. Anyway, could you show us some context about your extension? |
Hello @haroldrandom I believe that I have fixed the portion of the extension that you had commented on. This CLI extension is essentially to rebrand the existing hanaonazure extension with a slightly different set of support cases. |
d74507a
to
3d93cfe
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.