Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baremetal] Adding the baremetal extension to the overall cli extension repo #2510

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

pabowers
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/pabowers/azure-cli-extensions.git@pabowers/baremetalinfra-0.0.1#subdirectory=src/$EXT&egg=$EXT"

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 13, 2020

baremetal

@yonzhan yonzhan added this to the S177 milestone Oct 13, 2020
@haroldrandom
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@haroldrandom haroldrandom changed the title Adding the baremetal extension to the overall cli extension repo [baremetal] Adding the baremetal extension to the overall cli extension repo Oct 14, 2020
Copy link
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the name of the index entry

@haroldrandom
Copy link
Contributor

Hi, @pabowers @AprilZhaoWY! Nice to meet you. I believe it's the first time we meet in Azure CLI Extensions. I don't know whether you have contacted other ones on the team and they know the context or not.

Anyway, could you show us some context about your extension?

@pabowers
Copy link
Contributor Author

Hello @haroldrandom I believe that I have fixed the portion of the extension that you had commented on. This CLI extension is essentially to rebrand the existing hanaonazure extension with a slightly different set of support cases.

@pabowers pabowers requested a review from haroldrandom October 14, 2020 22:43
@pabowers pabowers force-pushed the pabowers/baremetalinfra-0.0.1 branch from d74507a to 3d93cfe Compare October 15, 2020 02:51
@haroldrandom haroldrandom merged commit e24d524 into Azure:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants