Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLC] Update source files with js suffix in imports #2987

Closed
Tracked by #2986
MaryGao opened this issue Jan 10, 2025 · 3 comments
Closed
Tracked by #2986

[HLC] Update source files with js suffix in imports #2987

MaryGao opened this issue Jan 10, 2025 · 3 comments

Comments

@MaryGao
Copy link
Member

MaryGao commented Jan 10, 2025

No description provided.

@MaryGao MaryGao mentioned this issue Jan 10, 2025
Open
@MaryGao
Copy link
Member Author

MaryGao commented Jan 10, 2025 •
edited
Loading

This issue may fix by pr #2925, @kazrael2119 could you help investigate if all changes are applied by the pr? Also ensure the flag module-kind is safe for current release.

@kazrael2119
Copy link
Contributor

If we want to use HLC to generate esm code, wo should add --module-kind=esm to enable it.
And all the files under src folder are added the .js suffix

@MaryGao
Copy link
Member Author

MaryGao commented Jan 10, 2025

Closed as fixed by #2925.

@MaryGao MaryGao closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaryGao @kazrael2119