Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prebuild from the generated package.json files #1176

Closed
sadasant opened this issue Aug 26, 2021 · 3 comments
Closed

Remove prebuild from the generated package.json files #1176

sadasant opened this issue Aug 26, 2021 · 3 comments
Assignees

Comments

@sadasant
Copy link

We recently realized that neither rush build nor rush rebuild call to prebuild. For this reason, we’ve opted for removing prebuild from the package.json files on the JS SDK, and now we run npm run clean && at the beginning of the build script.

Please help us make this change happen in the code generator, so that newly generated packages can take this change as well!

More information in the related JS SDK issue: Azure/azure-sdk-for-js#17125

@sadasant
Copy link
Author

Important: Do not add npm run clean && to the build script. See: Azure/azure-sdk-for-js#17540

@sadasant
Copy link
Author

wait, we are still discussing whether to remove “clean” from the build script

@sadasant
Copy link
Author

Ok, after chatting with @mikeharder and @xirzec we’ve decided to keep npm run clean && inside of the build step. Thank you for working on this, @JonathanCrd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants