Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Track1] The generated package.json has wrong homepage and misses autoPublish #1038

Closed
dw511214992 opened this issue Jun 16, 2021 · 8 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. v4
Milestone

Comments

@dw511214992
Copy link
Member

In Azure/azure-sdk-for-js#15767 and Azure/azure-sdk-for-js#15583, the generated package.json has wrong homepage and misses autoPublish.
To fix it in js sdk, I create a PR: Azure/azure-sdk-for-js#15768

@ramya-rao-a
Copy link
Contributor

@dw511214992 Can you share the exact command you used to generate the package? And which version of the code generator did you end up using?

@dw511214992
Copy link
Member Author

dw511214992 commented Jun 17, 2021

Hi @ramya-rao-a The PR is generated by @sarangan12. @sarangan12 Could you please provide the command you used?

I think the codegen depends on exsiting package.json. So it works for RPs which has been released previously, but has some issue for a new RP.

@deyaaeldeen
Copy link
Member

@sarangan12 I added some logic in the readme file generator to calculate the this URL, you could use that to populate this field in package.json as well.

@sarangan12
Copy link
Contributor

I have made sure autopublish is correctly generated for Track 2 packages. For Track 1, I agree we need to fix it. But, since we have already decided that the new packages are not going to be released in Track 1 (unless they have exceptions) So, this issue happening in Track 1 is rare. Moving this issue to backlog based on issue priority.

@sarangan12 sarangan12 added this to the Backlog milestone Jun 24, 2021
@deyaaeldeen
Copy link
Member

Oh I did not notice this is for Track1, ignore my comment earlier then.

@dw511214992
Copy link
Member Author

@sarangan12 what's value of autopublish you set in the track2 sdk? we will use the same release pipeline as dataplane, so I think the value should also be the same as dataplane's. thanks

@sarangan12 sarangan12 removed their assignment Jul 9, 2021
@sarangan12 sarangan12 added the v4 label Jul 16, 2021
@ramya-rao-a
Copy link
Contributor

We do not need the autoPublish field in Track 2 packages.

@dw511214992 Are you still seeing the issue of missing autoPublish field for Track 1 packages?

@sarangan12 sarangan12 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Nov 9, 2021
@sarangan12
Copy link
Contributor

I have checked and able to confirm autoPublish is getting generated correctly for Track 1 packages. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. v4
Projects
None yet
Development

No branches or pull requests

4 participants