Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generation failure for default: "false" #1492

Closed
msyyc opened this issue Oct 10, 2022 · 4 comments
Closed

generation failure for default: "false" #1492

msyyc opened this issue Oct 10, 2022 · 4 comments
Assignees
@msyyc
Labels
mgmt This issue is related to a management-plane library.

Comments

@msyyc
Copy link
Member

msyyc commented Oct 10, 2022 •
edited
Loading

for the swagger definition like:

          "type": "boolean",
          "default": "false"

Python generation will fail:
image
@msyyc msyyc added mgmt This issue is related to a management-plane library. DPG labels Oct 10, 2022
@msyyc msyyc self-assigned this Oct 10, 2022
@msyyc
Copy link
Member Author

msyyc commented Oct 10, 2022

after the issue is fixed, we need to remove directive in https://github.com/Azure/azure-rest-api-specs/pull/20931/files#diff-af988314b320a4f29b9ae598269992f574fd402e9250e03fe1c3ee8ce14eb995

@msyyc
Copy link
Member Author

msyyc commented Oct 10, 2022 •
edited
Loading

updated: it is swagger definition issue that it shall not be "false" but false . After Azure/azure-rest-api-specs#21044 merged, we can't remove the directive

@msyyc msyyc changed the title generation failure for default: false generation failure for default: "false" Oct 10, 2022
@iscai-msft
Copy link
Contributor

I don't think this is still an issue, can you close it @msyyc?

@msyyc
Copy link
Member Author

msyyc commented Oct 11, 2022

the swagger has been fixed: Azure/azure-rest-api-specs#21044

@msyyc msyyc closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iscai-msft @msyyc