-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way that we recognize a package as preview #484
Conversation
Out of interest will this also catch services which release preview versions in stable API's? Using Networking & AKS as examples |
This will ensure that if a go package is generated from several swaggers and there is at least one swagger is preview, the go package will be marked as preview. Previously we do not check this unless a set of swaggers are all preview. |
Have you tried building the SDK with this change? Do any packages now fail to build? |
Hi @jhendrixMSFT I am running a full scan of the swagger repo to see how many readme files need modifying. I will post the result here soon |
Given our reliance on this and how much we're iterating on it I think it would be wise to add tests to cover this scenario in CI. |
Hi @jhendrixMSFT I open a PR to fix the bad output-folders: Azure/azure-rest-api-specs#10842, you could get the list in the file changes. |
Could you please be more specific on this? I assume I could introduce some unit test for these new functions |
Unit tests for the detection of preview packages. I assume it's something run manually, likely building the entire SDK. Would be great to have something that runs as part of CI (can be a separate PR). |
🤖 AutoRest automatic publish job 🤖success (version: 2.1.157) |
This PR makes those tags that contains at least one preview swagger as a preview package.
Previously, a preview package is forced when all of the swaggers within a tag are preview.