Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way that we recognize a package as preview #484

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

ArcturusZhang
Copy link
Member

This PR makes those tags that contains at least one preview swagger as a preview package.

Previously, a preview package is forced when all of the swaggers within a tag are preview.

@tombuildsstuff
Copy link

Out of interest will this also catch services which release preview versions in stable API's? Using Networking & AKS as examples

@ArcturusZhang
Copy link
Member Author

This will ensure that if a go package is generated from several swaggers and there is at least one swagger is preview, the go package will be marked as preview.

Previously we do not check this unless a set of swaggers are all preview.

@jhendrixMSFT
Copy link
Member

Have you tried building the SDK with this change? Do any packages now fail to build?

@ArcturusZhang
Copy link
Member Author

Hi @jhendrixMSFT I am running a full scan of the swagger repo to see how many readme files need modifying. I will post the result here soon

@jhendrixMSFT
Copy link
Member

Given our reliance on this and how much we're iterating on it I think it would be wise to add tests to cover this scenario in CI.

@ArcturusZhang
Copy link
Member Author

Hi @jhendrixMSFT I open a PR to fix the bad output-folders: Azure/azure-rest-api-specs#10842, you could get the list in the file changes.

@ArcturusZhang
Copy link
Member Author

ArcturusZhang commented Sep 18, 2020

Given our reliance on this and how much we're iterating on it I think it would be wise to add tests to cover this scenario in CI.

Could you please be more specific on this? I assume I could introduce some unit test for these new functions

@jhendrixMSFT
Copy link
Member

Unit tests for the detection of preview packages. I assume it's something run manually, likely building the entire SDK. Would be great to have something that runs as part of CI (can be a separate PR).

@jhendrixMSFT jhendrixMSFT merged commit cb00618 into Azure:master Sep 25, 2020
@fearthecowboy
Copy link
Member

🤖 AutoRest automatic publish job 🤖

success (version: 2.1.157)

@ArcturusZhang ArcturusZhang deleted the flip-preview-check branch September 25, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants