Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running publisher pipeline specifying an older commit SHA doesn't pick the files from that commit but latest content in those files #499

Closed
klakshmikantha opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@klakshmikantha
Copy link

Release version

5.0.1

Describe the bug

When running publisher pipeline with commit id, I am trying to specify an older (not latest but one prior to latest) commit id to deploy those changes but it picks the latest content from those files (latest commit).
We would like to explore this to give an option to re-deploy an older commit changes in case it fails during initial execution and newer changes are made.

Expected behavior

The changes pertaining to the commit SHA specified in the publisher run should be picked and deployed and not the latest commit changes.

Actual behavior

Latest commit changes are taken even if an older commit id is specified.

Reproduction Steps

Pick a older (not latest) commit id and specify in publisher workflow and it picks the values from latest version of the files not the one present in the inputted commit id.

Copy link

github-actions bot commented Mar 7, 2024

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

@guythetechie
Copy link
Contributor

@klakshmikantha - thanks for raising this. It is a known bug and will be fixed in our next major release.

@guythetechie guythetechie moved this to 👀 In review in APIOPS Roadmap Mar 11, 2024
@waelkdouh waelkdouh added the bug Something isn't working label Mar 11, 2024
@klakshmikantha
Copy link
Author

Thank you for the confirmation @guythetechie .

@waelkdouh
Copy link
Contributor

waelkdouh commented Jul 3, 2024

@klakshmikantha we just tested under v6.0.0-rc1 and the issue has been resolved. Please test and let us know.

@waelkdouh waelkdouh moved this from 👀 In review to ✅ Done in APIOPS Roadmap Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants