Create duplication of common/max folder and name it waf-aligned (+ update serviceShort *waf)

[eriqua]

# Generate WAF folder
	
$testFolderPaths=(Get-ChildItem -Filter 'e2e' -Directory -Recurse).FullName
foreach ($testFolderPath in $testFolderPaths) {
	$wafFolderPath = Join-Path $testFolderPath 'waf-aligned'
	if (-not (Test-Path $wafFolderPath)) {
        # Duplicate 'max' test folder
        $null = New-Item -Path $wafFolderPath -ItemType 'Directory' -Force
        $maxFolderPath = Join-Path $testFolderPath 'max'
		if (Test-Path $maxFolderPath) {
			$null = Copy-Item -Path "$maxFolderPath/*" -Destination $wafFolderPath -Recurse
		}
    }
}

# Update serviceShort & metadata

$wafFolderPaths=(Get-ChildItem -Filter 'waf-aligned' -Directory -Recurse).FullName
foreach ($testFolderPath in $wafFolderPaths) {
	$testContent = Get-Content (Join-Path $testFolderPath 'main.test.bicep') -Raw
    $testContent = $testContent -replace "(param serviceShort string = '[a-zA-Z]+)max'", ("`$1{0}'" -f 'waf')
	$testContent = $testContent -replace "metadata name = 'Using large parameter set'", "metadata name = 'WAF-aligned'"
	$testContent = $testContent -replace "metadata description = 'This instance deploys the module with most of its features enabled.'", "metadata description = 'This instance deploys the module in alignment with the best-practices of the Azure Well-Architected Framework.'"
	$null = Set-Content (Join-Path $testFolderPath 'main.test.bicep') -Value $testContent -Force -NoNewline
}

[AlexanderSehr]

Question @eriqua, should we do any scripted changes here, for example remove role assignments, if any?

[eriqua]

Not a bad idea at all. Should we take that in a separate issue? Just because the PR is ready and I'd expect some time to choose what to remove if present.

[AlexanderSehr]

@eriqua, I think the value of the PR is limited if it's simple copy (and updated prefix). However, I guess it is an acceptable middle-step, so I'll see to review it.

[eriqua]

@eriqua, I think the value of the PR is limited if it's simple copy (and updated prefix). However, I guess it is an acceptable middle-step, so I'll see to review it.

Duplication, serviceShort and metadata. That's what the module update script would have done at module level anyway so I'd disagree on the PR value :)

[AlexanderSehr]

The original yes. The suggestion would have been to alter it 😏 but I can take care of that after