Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Orphaned Module]: avm/res/sql/server #1141

Closed
matebarabas opened this issue Jun 25, 2024 · 15 comments
Closed

[Orphaned Module]: avm/res/sql/server #1141

matebarabas opened this issue Jun 25, 2024 · 15 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified

Comments

@matebarabas
Copy link
Contributor

matebarabas commented Jun 25, 2024

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/sql/server

Module Details

This module was previously owned by @bryansan-msft. When a new owner volunteers, the related GitHub teams need to be handed over by Bryan.

Original module proposal: #295

Do you want to be the new owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@matebarabas matebarabas added Needs: Triage 🔍 Maintainers need to triage still Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module labels Jun 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Jun 25, 2024
@emichellecarter
Copy link

I am willing to take the maintenance on this module.

@matebarabas
Copy link
Contributor Author

Hi @emichellecarter,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Aug 5, 2024
@matebarabas matebarabas added Status: Owners Identified 🤘 This module has its owners identified and removed Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Aug 5, 2024
@send-itDuong
Copy link

Can we get confirmation that this module is no longer orphaned? The README file still indicate that it still is.

Thanks!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Aug 7, 2024
@matebarabas
Copy link
Contributor Author

Hi @send-itDuong, the ownership is not yet transferred to @emichellecarter as her response to the above is still pending.

@emichellecarter
Copy link

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER. Thank you

@matebarabas
Copy link
Contributor Author

Hi @emichellecarter,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Aug 7, 2024
@matebarabas
Copy link
Contributor Author

@bryansan-msft, can you please hand over the ownership of the 2 related GitHub teams to @emichellecarter?

@emichellecarter, can you Please also remove the ORPHANED.md file from the module's folder and its content from the README.md, by following the steps described in point 5 here and let me know in a comment when this is done. Thanks!

@bryansan-msft
Copy link

Hello @matebarabas I am no longer member of any of the sql teams so I cant do that

@matebarabas
Copy link
Contributor Author

@bryansan-msft, thanks for letting me know. With no members remaining in these two teams, we lost access to them, so we'll need to involve GH support, which might take longer. I'll take care of this.

@bryansan-msft
Copy link

You are a maintainer of the parent team. I am sure you can add him yourself

@matebarabas
Copy link
Contributor Author

matebarabas commented Aug 8, 2024

That's what we'd all hope for, but unfortunately that's not how teams work on GitHub. :) We've run into this once, and managed to solve it, so it will be fixed this time as well, it's just going to take some time. But don't worry about this, I'll handle it.

@matebarabas
Copy link
Contributor Author

@emichellecarter, the request just went through. You should now be a maintainer in both teams. Please let me know when the orphaned.md file is updated too, so we can close this issue. Thank you!

@peterbud
Copy link

@matebarabas : Would it make sense to have two co-owners for this module? If yes, I'd be interested

@matebarabas
Copy link
Contributor Author

@peterbud, each module can have 1 owner (primary owner), 1 co-owner (secondary owner), and any number of contributors. As @emichellecarter is now the owner of this module, you can definitely be its secondary owner. Should I sign you up?

PS: @emichellecarter, I can see the orphaned.md has been updated, so I'm closing this issue now.

@github-project-automation github-project-automation bot moved this from Proposed to Done in AVM - Module Triage Sep 17, 2024
@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Needs: Triage 🔍 Maintainers need to triage still Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Sep 17, 2024
@peterbud
Copy link

Yes, pls sign me up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified
Projects
Development

No branches or pull requests

5 participants